refactor: add declare strict_types to all classes in ./src (#758)

* refactor: add declare strict_types to all classes in ./src

* fix: correct regression from adding declare strict_types

* refactor: enforce string at datetime casting

* docs: add changelog entry

Author: DannyvdSluijs

CHANGELOG.md

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema;
 
 use JsonSchema\Exception\InvalidArgumentException;

src/JsonSchema/ConstraintError.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/BaseConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/CollectionConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/ConstConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/Constraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/ConstraintInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/EnumConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/Factory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *
@@ -174,7 +176,7 @@ public function check(&$element, $schema = null, ?JsonPointer $path = null, $i =
 
     protected function validateDateTime($datetime, $format)
     {
-        $dt = \DateTime::createFromFormat($format, $datetime);
+        $dt = \DateTime::createFromFormat($format, (string) $datetime);
 
         if (!$dt) {
             return false;

src/JsonSchema/Constraints/FormatConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/NumberConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/ObjectConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/SchemaConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/StringConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema\Constraints\TypeCheck;
 
 class LooseTypeCheck implements TypeCheckInterface

src/JsonSchema/Constraints/TypeCheck/LooseTypeCheck.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema\Constraints\TypeCheck;
 
 class StrictTypeCheck implements TypeCheckInterface

src/JsonSchema/Constraints/TypeCheck/StrictTypeCheck.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema\Constraints\TypeCheck;
 
 interface TypeCheckInterface

src/JsonSchema/Constraints/TypeCheck/TypeCheckInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/TypeConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Constraints/UndefinedConstraint.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *
@@ -120,7 +122,7 @@ public function getPropertyPaths()
     public function withPropertyPaths(array $propertyPaths)
     {
         $new = clone $this;
-        $new->propertyPaths = $propertyPaths;
+        $new->propertyPaths = array_map(function ($p): string { return (string) $p; }, $propertyPaths);
 
         return $new;
     }

src/JsonSchema/Entity/JsonPointer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema;
 
 abstract class Enum extends \MabeEnum\Enum

src/JsonSchema/Enum.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema\Exception;
 
 interface ExceptionInterface

src/JsonSchema/Exception/ExceptionInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/InvalidArgumentException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/InvalidConfigException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/InvalidSchemaException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/InvalidSchemaMediaTypeException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/InvalidSourceUriException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/JsonDecodingException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/ResourceNotFoundException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/RuntimeException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/UnresolvableJsonPointerException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/UriResolverException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Exception/ValidationException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Iterator/ObjectIterator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema;
 
 class Rfc3339

src/JsonSchema/Rfc3339.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema;
 
 use JsonSchema\Constraints\BaseConstraint;

src/JsonSchema/SchemaStorage.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema;
 
 interface SchemaStorageInterface

src/JsonSchema/SchemaStorageInterface.php

@@ -1,4 +1,7 @@
 <?php
+
+declare(strict_types=1);
+
 /**
  * JsonSchema
  *

src/JsonSchema/Uri/Retrievers/AbstractRetriever.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Uri/Retrievers/Curl.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Uri/Retrievers/FileGetContents.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace JsonSchema\Uri\Retrievers;
 
 use JsonSchema\Validator;

src/JsonSchema/Uri/Retrievers/PredefinedArray.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Uri/Retrievers/UriRetrieverInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Uri/UriResolver.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/Uri/UriRetriever.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/UriResolverInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *

src/JsonSchema/UriRetrieverInterface.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the JsonSchema package.
  *