For missing properties, the key for that error in set to ""

- Expected bahavior is that the key would be set to the poperty name.
- added tests to ensure the "property" is populated regardless
of required attribute is completely missing or has empty value.

Author: samkeen

src/JsonSchema/Constraints/UndefinedConstraint.php

@@ -122,7 +122,7 @@ protected function validateCommonProperties($value, $schema = null, $path = null
                 // Draft 4 - Required is an array of strings - e.g. "required": ["foo", ...]
                 foreach ($schema->required as $required) {
                     if (!property_exists($value, $required)) {
-                        $this->addError($path, "the property " . $required . " is required");
+                        $this->addError($required, "the property " . $required . " is required");
                     }
                 }
             } else if (isset($schema->required) && !is_array($schema->required)) {

tests/JsonSchema/Tests/Constraints/RequiredPropertyTest.php

@@ -9,8 +9,60 @@
 
 namespace JsonSchema\Tests\Constraints;
 
+use JsonSchema\Constraints\UndefinedConstraint;
+
 class RequiredPropertyTest extends BaseTestCase
 {
+
+    public function testErrorPropertyIsPopulatedForRequiredIfMissingInInput()
+    {
+        $validator = new UndefinedConstraint();
+        $document = json_decode('{
+            "bar": 42
+        }');
+        $schema = json_decode('{
+            "type": "object",
+            "properties": {
+                "foo": {"type": "number"},
+                "bar": {"type": "number"}
+            },
+            "required": ["foo"]
+        }');
+
+        $validator->check($document, $schema);
+        $error = $validator->getErrors();
+        if(!isset($error[0]['property'])) {
+            $this->fail("Malformed error response. Expected \$error[0]['property'] to be set. Error response was "
+                . json_encode($error));
+        }
+        $this->assertEquals('foo', $error[0]['property']);
+    }
+
+    public function testErrorPropertyIsPopulatedForRequiredIfEmptyValueInInput()
+    {
+        $validator = new UndefinedConstraint();
+        $document = json_decode('{
+            "bar": 42,
+            "foo": null
+        }');
+        $schema = json_decode('{
+            "type": "object",
+            "properties": {
+                "foo": {"type": "number"},
+                "bar": {"type": "number"}
+            },
+            "required": ["foo"]
+        }');
+
+        $validator->check($document, $schema);
+        $error = $validator->getErrors();
+        if(!isset($error[0]['property'])) {
+            $this->fail("Malformed error response. Expected \$error[0]['property'] to be set. Error response was "
+                . json_encode($error));
+        }
+        $this->assertEquals('foo', $error[0]['property']);
+    }
+
     public function getInvalidTests()
     {
         return array(