Skip to content

Rename some href* keywords to template* #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2017

Conversation

handrews
Copy link
Contributor

@handrews handrews commented Sep 23, 2017

Addresses part of #416. Since "href", "anchor", and "base" all share the use of "hrefPointers" and "hrefRequired", let's call them something more generic. Note that since "hrefSchema" is NOT used with "anchor", it retains its existing name.

I am not particularly attached to the template* prefix. I considered uri*, but then would we want to change it to iri*? So I went with template*. But other suggestions are welcome.

Addresses part of json-schema-org#416.  Since "href", "anchor", and "base"
all share the use of "hrefPointers" and "hrefRequired",
let's call them something more generic.  Note that since
"hrefSchema" is NOT used with "anchor", it retains its
existing name.
@handrews handrews added this to the draft-07 (wright-*-02) milestone Sep 23, 2017
@handrews handrews changed the title Rename some href* keywords to template Rename some href* keywords to template* Sep 23, 2017
@dlax
Copy link
Member

dlax commented Sep 25, 2017

Renaming the keywords doesn't seem sufficient because most of surrounding texts still refers to href only (see https://github.com/handrews/json-schema-spec/blob/b01c13a6d1744f5bbe0ad4339b60bdc38ffaf414/jsonschema-hyperschema.xml#L358 for instance). Maybe it's just a first step and you plan to rework this as part of the rewrite?

The template prefix looks fine, I don't have a better idea at the moment.

@handrews
Copy link
Contributor Author

@dlax see #419 and, more importantly, #425.

@handrews handrews changed the base branch from href-req to master September 27, 2017 21:09
@handrews
Copy link
Contributor Author

@dlax you can now see this in context in #427

@dlax
Copy link
Member

dlax commented Sep 28, 2017 via email

@handrews
Copy link
Contributor Author

handrews commented Oct 8, 2017

@dlax I'm taking your last comment as an approval. Let me know if that's not correct and we'll sort it out / revert / change further / etc.

@handrews handrews merged commit 7be79b4 into json-schema-org:master Oct 8, 2017
@handrews handrews deleted the template-not-href branch October 8, 2017 02:22
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Maintenance labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants