This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Clarify the meaning of the draft qualifier #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for condescending-hopper-c3ed30 ready! 🔨 Explore the source changes: 11d2ab1 🔍 Inspect the deploy log: https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/60e4885c7f2e14000759a349 😎 Browse the preview: https://deploy-preview-399--condescending-hopper-c3ed30.netlify.app/ |
aucampia
force-pushed
the
iwana-project_status
branch
from
c7107bd to
a7ae96b
Compare
jdesrosiers
suggested changes
Jul 5, 2021
Fix grammar Co-authored-by: Jason Desrosiers <[email protected]>
handrews
reviewed
Jul 5, 2021
|
I'm quite happy with this. Definitely a clarification that needs to be made. Thanks for writing it up. |
Also change "qualifier" to "designation", and fix grammar in third paragraph.
jdesrosiers
approved these changes
Jul 6, 2021
Relequestual
reviewed
Jul 6, 2021
Relequestual
suggested changes
Jul 6, 2021
add oxford comma Co-authored-by: Ben Hutton <[email protected]>
Relequestual
approved these changes
Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to this discussion: json-schema-org/community#25
This is my understanding from discussions and the presentation made by Ben Hutton.
Feedback welcome, I realize that this is something quite critical and should be changed with care and consideration so I expect that there will be significant changes to this before it is merged.