Skip to content

definitions.json should be renamed #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awwright opened this issue Jan 24, 2018 · 2 comments
Closed

definitions.json should be renamed #214

awwright opened this issue Jan 24, 2018 · 2 comments

Comments

@awwright
Copy link
Member

"definitions.json" suggests it'll be about the keyword "definitions" instead of the meta-schema.

Perhaps we should move this file, and meta-schema tests from ref.json, into its own file under optional?

@Julian
Copy link
Member

Julian commented May 12, 2018

+1, but I think we should address #223 first

@Julian Julian added the missing test A request to add a test to the suite that is currently not covered elsewhere. label May 12, 2018
@Julian Julian added bug A test is wrong, or tooling is broken or buggy. and removed missing test A request to add a test to the suite that is currently not covered elsewhere. labels Oct 12, 2019
@Julian Julian removed the bug A test is wrong, or tooling is broken or buggy. label Jul 31, 2022
@Julian
Copy link
Member

Julian commented Jul 31, 2022

Over time I think we've continued to put meta schema tests alongside the same file and I guess it's worked OK. Perhaps at some point we should formally restructure things a bit, but will maybe close this for now. These tests are not optional definitely, they rely on properly implementing all the validators used in the meta-schema, which are of course the same ones required for implementation.

@Julian Julian closed this as completed Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants