Skip to content

Check method GetResourceContext(type) returns null #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

farturi
Copy link

@farturi farturi commented Jan 27, 2021

Check if method GetResourceContext(type) returns null before returning Relationships

Closes #{ISSUE_NUMBER}

QUALITY CHECKLIST

  • Changes implemented in code
  • Adapted tests
  • Documentation updated
  • Created issue to update Templates: {ISSUE_NUMBER}

Check if method GetResourceContext(type) returns null before returning Relationships
@bart-degreed
Copy link
Contributor

This is a breaking change. Where the call would have failed before, it now silently hides the error. What's the reason for changing this?

@farturi
Copy link
Author

farturi commented Jan 27, 2021

Hi Bart, this is to fix this problem:
#924

@bart-degreed
Copy link
Contributor

I appreciate that you're trying to help, but I think this is not the right solution. Instead, the caller should be changed to not send an invalid type.

@farturi farturi closed this Jan 27, 2021
@farturi farturi deleted the patch-1 branch January 27, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants