Relationship endpoint bugfixes, implement POST and DELETE on to-many relationship link#851

Closed

maurei wants to merge 274 commits intomasterfrom

feat/post-relationship-link-353

This pull request is big! We're only showing the most recent 250 commits

Commits on Oct 6, 2020

Commits on Oct 7, 2020

feat: implemented new pipeline elements for the repository, performed some refactoring and processed review feedback
maurei
committed
fix: merge
maurei
committed

Commits on Oct 12, 2020

chore: self review
maurei
committed
Refactored AddRepositoryLayer/AddServiceLayer
Bart Koelman
committed
fix broken tests
Bart Koelman
committed
fix logging
Bart Koelman
committed
relationship renames and documentation
Bart Koelman
committed
renamed exception
Bart Koelman
committed
First steps in error refactoring
Bart Koelman
committed
removed comments
Bart Koelman
committed
chore: refactor service layer
maurei
committed
chore: cleanup
maurei
committed
fix: test error missing relationship assignment resources
maurei
committed
feat: support for composite foreign keys
maurei
committed
feat: return secondary resources from GetRelationshipAsync service pipeline
maurei
committed

Commits on Oct 13, 2020

fix broken build
Bart Koelman
committed
fix broken tests
Bart Koelman
committed
Cleanup RepositoryAccessor
Bart Koelman
committed
Merge branch 'master' into feat/post-relationship-link-353
Bart Koelman
committed
TopFieldSelection
Bart Koelman
committed
fixes and cleanup
Bart Koelman
committed
test: test cases for set RequestRelationship no longer relevant
maurei
committed
tests: missing resources in relationship endpoint tests
maurei
committed
Refactored mising resources in relationships at service layer
Bart Koelman
committed
plural naming because it may affect multiple relationships
Bart Koelman
committed
Merge remote-tracking branch 'upstream/master' into feat/post-relationship-link-353
Bart Koelman
committed
fixed broken build
Bart Koelman
committed

Commits on Oct 14, 2020

more cleanup
Bart Koelman
committed
repository renames
Bart Koelman
committed
fixed test for composite foreign keys
Bart Koelman
committed
Temporary snapshot for work in progress...
Bart Koelman
committed
Rewrite of UpdatingRelationshipsTests to new syntax
Bart Koelman
committed

Commits on Oct 15, 2020

fixed broken test
Bart Koelman
committed
fixed broken test
Bart Koelman
committed
refactored inverse navigation handling
Bart Koelman
committed
Merge branch 'master' into feat/post-relationship-link-353
Bart Koelman
committed
fix: broken tests except for missing primary resource test
maurei
committed
fix: merge
maurei
committed
cleanup
Bart Koelman
committed
fix test
Bart Koelman
committed
renames
Bart Koelman
committed
revert diff
Bart Koelman
committed
feat: remove excess inverse loading logic
maurei
committed
Refactored CreatingDataTests to use new syntax
Bart Koelman
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
Bart Koelman
committed

Commits on Oct 16, 2020

various comments
Bart Koelman
committed
added tests to ModelStateValidationTests for new endpoints
Bart Koelman
committed
more cleanup
Bart Koelman
committed
test: skip injectable resource test until efcore 5 lands
maurei
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
maurei
committed
Merged tests
Bart Koelman
committed
move/merge tests
Bart Koelman
committed
isolated tests with composite primary key
Bart Koelman
committed
Added TODO
Bart Koelman
committed
clean; update test to allow deleting non-existing relationship
Bart Koelman
committed
added remarks
Bart Koelman
committed

Commits on Oct 18, 2020

Commits on Oct 19, 2020

Commits on Oct 20, 2020

chore: refactor
maurei
committed
chore: refactor using EnsureCompleteReplacement, add two todos
maurei
committed
chore: add todo
maurei
committed
renames
Bart Koelman
committed
changes on resource factory
Bart Koelman
committed
chore: refactor proposal
maurei
committed
chore: add comment
maurei
committed
chore: rename
maurei
committed
comments
Bart Koelman
committed
fix: Todo item on NoContent in PatchAsync controller method
maurei
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
Bart Koelman
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
Bart Koelman
committed
revert: removed assertions on response body
Bart Koelman
committed
revert name changes
Bart Koelman
committed
Use ISet in public signatures
Bart Koelman
committed
made public
Bart Koelman
committed

Commits on Oct 21, 2020

docs update
Bart Koelman
committed
Refactored and isolated tests for resource creation (without relationships)
Bart Koelman
committed
Added tests for create with relationships
Bart Koelman
committed

Commits on Oct 22, 2020

Commits on Oct 23, 2020

more on tests
Bart Koelman
committed
chore: review
maurei
committed
fix: resource factory null check
maurei
committed
chore: review
maurei
committed
chore: static setter ResourceFactory HasManyThroughAttribute
maurei
committed
revert
maurei
committed
fix: Remove AsNoTracking in favour of explicit loading
maurei
committed
Moved tests from the wrong folder
Bart Koelman
committed
fix test
Bart Koelman
committed
Tests for posting to HasMany relationship through relationship endpoint
Bart Koelman
committed
fix flaky test
Bart Koelman
committed
Deterministic fakers
Bart Koelman
committed

Commits on Oct 24, 2020

Updates on TODOs
Bart Koelman
committed
reduced test duplication
Bart Koelman
committed
Added tests for removing from to-many relationships through DELETE relationship endpoint
Bart Koelman
committed
tomany test tweaks
Bart Koelman
committed
removed old test
Bart Koelman
committed
more on tests
Bart Koelman
committed

Commits on Oct 26, 2020

rename test
Bart Koelman
committed
Fixed: let fakers generate different data on subsequent calls within a single test.
Bart Koelman
committed
Added tests for update to-one relationships through relationships endpoint
Bart Koelman
committed
Refactor tests: .Where(expr).FirstAsync() -> .FirstAsync(expr)
Bart Koelman
committed
Added tests for updating to-many relationships through relationships endpoint
Bart Koelman
committed
fixed: missing null check
Bart Koelman
committed
Fix for disabled test: Cannot_remove_for_relationship_mismatch_between_url_and_body
Bart Koelman
committed
feat: remove already related resources from assignment with expression trees
maurei
committed
fix: merge
maurei
committed

Commits on Oct 27, 2020

cleanup
Bart Koelman
committed
chore: improved GetFilteredThroughEntities call and reused it in EnableCompleteReplacement
maurei
committed
merge
maurei
committed
renames
Bart Koelman
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
Bart Koelman
committed
Revert: commented-out code. This is needed to guard internal consistency. Parsers prevent this exception from being thrown, but you can hit it from a ResourceDefinition override. This guard is simi…
Bart Koelman
committed
updated test
Bart Koelman
committed
Clarified documentation that PATCH replaces relationships.
Bart Koelman
committed
added tests for missing cases
Bart Koelman
committed
changed tests order for consistency
Bart Koelman
committed
Added tests for updating to-one relationships through primary endpoint
Bart Koelman
committed
chore: review, remove resource factory, todos
maurei
committed
chore: add todos
maurei
committed
Added tests for updating to-many relationships through primary endpoint
Bart Koelman
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
Bart Koelman
committed
chore: review
maurei
committed
Merge branch 'feat/post-relationship-link-353' of https://github.com/json-api-dotnet/JsonApiDotNetCore into feat/post-relationship-link-353
maurei
committed
revert changes
Bart Koelman
committed

Commits on Oct 28, 2020

Commits on Oct 29, 2020

merge
maurei
committed
chore: add review todos
maurei
committed
chore: review todos
maurei
committed
fix broken build
Bart Koelman
committed
cleanup hooks
Bart Koelman
committed
Use public name in error for setting read-only attribute.
Bart Koelman
committed
Hooks: do not execute only if default non-empty implemenation is active (this breaks the pluggable nature of injection). Instead make the do-nothing version really do nothing instead of throwing an…
Bart Koelman
committed
FirstAsync TODOs
Bart Koelman
committed
revert whitespace changes
Bart Koelman
committed
revert unneeded whitespace changes
Bart Koelman
committed
Clarified test names for blocked usage
Bart Koelman
committed
Replacement of ToListAsync with FirstAsync in tests
Bart Koelman
committed
Renamed WorkItem.AssignedTo to WorkItem.Assignee
Bart Koelman
committed
test improvements
Bart Koelman
committed
Fail with status Conflict for pre-existing resource ID in POST.
Bart Koelman
committed
Fail when trying to update resource ID
Bart Koelman
committed

Commits on Oct 30, 2020

Commits on Nov 2, 2020

Commits on Nov 3, 2020

Commits on Nov 4, 2020