Acceptance tests EF inheritance (#610)

* chore: create inheritance model + controller

* test: create and patch acceptance test

* chore: close issue

Author: maurei

src/Examples/JsonApiDotNetCoreExample/Controllers/UsersController.cs

@@ -15,4 +15,14 @@ public UsersController(
             : base(jsonApiOptions, resourceService, loggerFactory)
         { }
     }
+
+    public class SuperUsersController : JsonApiController<SuperUser>
+    {
+        public SuperUsersController(
+            IJsonApiOptions jsonApiOptions,
+            IResourceService<SuperUser> resourceService,
+            ILoggerFactory loggerFactory)
+            : base(jsonApiOptions, resourceService, loggerFactory)
+        { }
+    }
 }

src/Examples/JsonApiDotNetCoreExample/Data/AppDbContext.cs

@@ -14,6 +14,7 @@ public class AppDbContext : DbContext
         public DbSet<Author> AuthorDifferentDbContextName { get; set; }
         public DbSet<NonJsonApiResource> NonJsonApiResources { get; set; }
         public DbSet<User> Users { get; set; }
+        public DbSet<SuperUser> SuperUsers { get; set; }
         public DbSet<PersonRole> PersonRoles { get; set; }
         public DbSet<ArticleTag> ArticleTags { get; set; }
         public DbSet<IdentifiableArticleTag> IdentifiableArticleTags { get; set; }
@@ -23,6 +24,8 @@ public AppDbContext(DbContextOptions<AppDbContext> options) : base(options) { }
 
         protected override void OnModelCreating(ModelBuilder modelBuilder)
         {
+            modelBuilder.Entity<SuperUser>().HasBaseType<User>();
+
             modelBuilder.Entity<TodoItem>()
                 .Property(t => t.CreatedDate).HasDefaultValueSql("CURRENT_TIMESTAMP").IsRequired();
 

src/Examples/JsonApiDotNetCoreExample/Models/User.cs

@@ -8,4 +8,9 @@ public class User : Identifiable
         [Attr] public string Username { get; set; }
         [Attr] public string Password { get; set; }
     }
+
+    public class SuperUser : User
+    {
+        [Attr] public int SecurityLevel { get; set; }
+    }
 }

src/JsonApiDotNetCore/Internal/DefaultRoutingConvention.cs

@@ -58,6 +58,7 @@ public void Apply(ApplicationModel application)
             foreach (var controller in application.Controllers)
             {
                 var resourceType = GetResourceTypeFromController(controller.ControllerType);
+
                 if (resourceType != null)
                     _registeredResources.Add(controller.ControllerName, resourceType);
 

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/CreatingDataTests.cs

@@ -36,6 +36,23 @@ public CreatingDataTests(TestFixture<Startup> fixture) : base(fixture)
 
         }
 
+        [Fact]
+        public async Task CreateResource_ModelWithEntityFrameworkInHeritance_IsCreated()
+        {
+            // Arrange
+            var dbContext = PrepareTest<Startup>();
+            var serializer = GetSerializer<SuperUser>(e => new { e.SecurityLevel, e.Username, e.Password });
+            var superUser = new SuperUser { SecurityLevel = 1337, Username = "Super", Password = "User" };
+
+            // Act
+            var (body, response) = await Post("/api/v1/super-users", serializer.Serialize(superUser));
+
+            // Assert
+            AssertEqualStatusCode(HttpStatusCode.Created, response);
+            var createdSuperUser = _deserializer.DeserializeSingle<SuperUser>(body).Data;
+            var created = dbContext.SuperUsers.Where(e => e.Id.Equals(createdSuperUser.Id)).First();
+        }
+
         [Fact]
         public async Task CreateResource_GuidResource_IsCreated()
         {

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/EndToEndTest.cs

@@ -61,6 +61,11 @@ public AppDbContext GetDbContext()
             return SendRequest("POST", route, content);
         }
 
+        public Task<(string, HttpResponseMessage)> Patch(string route, string content)
+        {
+            return SendRequest("PATCH", route, content);
+        }
+
         public IRequestSerializer GetSerializer<TResource>(Expression<Func<TResource, dynamic>> attributes = null, Expression<Func<TResource, dynamic>> relationships = null) where TResource : class, IIdentifiable
         {
             return _fixture.GetSerializer(attributes, relationships);

test/JsonApiDotNetCoreExampleTests/Acceptance/Spec/UpdatingDataTests.cs

@@ -20,15 +20,15 @@
 namespace JsonApiDotNetCoreExampleTests.Acceptance.Spec
 {
     [Collection("WebHostCollection")]
-    public class UpdatingDataTests
+    public class UpdatingDataTests : EndToEndTest
     {
         private TestFixture<Startup> _fixture;
         private AppDbContext _context;
         private Faker<TodoItem> _todoItemFaker;
         private Faker<Person> _personFaker;
 
-        public UpdatingDataTests(TestFixture<Startup> fixture)
-        {
+        public UpdatingDataTests(TestFixture<Startup> fixture) : base(fixture)
+        { 
             _fixture = fixture;
             _context = fixture.GetService<AppDbContext>();
 
@@ -41,6 +41,25 @@ public UpdatingDataTests(TestFixture<Startup> fixture)
                 .RuleFor(p => p.LastName, f => f.Name.LastName());
         }
 
+        [Fact]
+        public async Task PatchResource_ModelWithEntityFrameworkInHeritance_IsPatched()
+        {
+            // Arrange
+            var dbContext = PrepareTest<Startup>();
+            var serializer = GetSerializer<SuperUser>(e => new { e.SecurityLevel });
+            var superUser = new SuperUser { SecurityLevel = 1337, Username = "Super", Password = "User" };
+            dbContext.SuperUsers.Add(superUser);
+            dbContext.SaveChanges();
+            var su = new SuperUser { Id = superUser.Id, SecurityLevel = 2674 };
+
+            // Act
+            var (body, response) = await Patch($"/api/v1/super-users/{su.Id}", serializer.Serialize(su));
+
+            // Assert
+            AssertEqualStatusCode(HttpStatusCode.OK, response);
+            var updated = _deserializer.DeserializeSingle<SuperUser>(body).Data;
+            Assert.Equal(2674, updated.SecurityLevel);
+        }
 
         [Fact]
         public async Task Response400IfUpdatingNotSettableAttribute()

test/JsonApiDotNetCoreExampleTests/Acceptance/TestFixture.cs

@@ -52,6 +52,7 @@ public IResponseDeserializer GetDeserializer()
                 .AddResource<Tag>()
                 .AddResource<CamelCasedModel>()
                 .AddResource<User>()
+                .AddResource<SuperUser>()
                 .AddResource<Person>()
                 .AddResource<Author>()
                 .AddResource<Passport>()