Add test for length attribute on collection

Author: verdie-g

test/OpenApiNSwagEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs

@@ -285,6 +285,39 @@ public async Task Cannot_use_invalid_url()
         errorObject.Source.Pointer.Should().Be("/data/attributes/backgroundPicture");
     }
 
+    [Theory]
+    [InlineData(0)]
+    [InlineData(11)]
+    public async Task Cannot_exceed_collection_length_constraint(int length)
+    {
+        // Arrange
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
+        ModelStateValidationClient apiClient = new(httpClient);
+
+        // Act
+        Func<Task<SocialMediaAccountPrimaryResponseDocument>> action = () => apiClient.PostSocialMediaAccountAsync(new SocialMediaAccountPostRequestDocument
+        {
+            Data = new SocialMediaAccountDataInPostRequest
+            {
+                Attributes = new SocialMediaAccountAttributesInPostRequest
+                {
+                    LastName = "",
+                    Tags = Enumerable.Repeat("", length).ToArray(),
+                }
+            }
+        });
+
+        // Assert
+        ErrorResponseDocument document = (await action.Should().ThrowExactlyAsync<ApiException<ErrorResponseDocument>>()).Which.Result;
+        document.Errors.ShouldHaveCount(1);
+
+        ErrorObject errorObject = document.Errors.First();
+        errorObject.Title.Should().Be("Input validation failed.");
+        errorObject.Detail.Should().Be("The field Tags must be a string or collection type with a minimum length of '1' and maximum length of '10'.");
+        errorObject.Source.ShouldNotBeNull();
+        errorObject.Source.Pointer.Should().Be("/data/attributes/tags");
+    }
+
     [Fact]
     public async Task Cannot_use_non_allowed_value()
     {
@@ -300,7 +333,7 @@ public async Task Cannot_use_non_allowed_value()
                 Attributes = new SocialMediaAccountAttributesInPostRequest
                 {
                     LastName = "",
-                    CountryCode = "US"
+                    CountryCode = "XX"
                 }
             }
         });

test/OpenApiTests/ModelStateValidation/ModelStateValidationFakers.cs

@@ -27,7 +27,7 @@ public sealed class ModelStateValidationFakers
         .RuleFor(socialMediaAccount => socialMediaAccount.Age, faker => faker.Random.Double(0.1, 122.9))
         .RuleFor(socialMediaAccount => socialMediaAccount.ProfilePicture, faker => new Uri(faker.Image.LoremFlickrUrl()))
         .RuleFor(socialMediaAccount => socialMediaAccount.BackgroundPicture, faker => faker.Image.LoremFlickrUrl())
-        .RuleFor(socialMediaAccount => socialMediaAccount.Tags, faker => faker.Make(faker.Random.Number(0, 10), () => faker.Random.String2(2, 10)))
+        .RuleFor(socialMediaAccount => socialMediaAccount.Tags, faker => faker.Make(faker.Random.Number(1, 10), () => faker.Random.String2(2, 10)))
         .RuleFor(socialMediaAccount => socialMediaAccount.CountryCode, faker => faker.Random.ListItem(["NL", "FR"]))
         .RuleFor(socialMediaAccount => socialMediaAccount.Planet, faker => faker.Random.String2(2, 8))
         .RuleFor(socialMediaAccount => socialMediaAccount.NextRevalidation, faker => TimeSpan.FromMinutes(faker.Random.Number(1, 5)))

test/OpenApiTests/ModelStateValidation/SocialMediaAccount.cs

@@ -63,7 +63,7 @@ public sealed class SocialMediaAccount : Identifiable<Guid>
 
     [Attr]
 #if NET8_0_OR_GREATER
-    [Length(0, 10)]
+    [Length(1, 10)]
 #endif
     public List<string>? Tags { get; set; }