Apply suggestions from code review

verdie-g · bkoelman · web-flow · commit 8f0e849cb05e · 2024-06-19T18:23:58.000-04:00
Co-authored-by: Bart Koelman &lt;10324372+bkoelman@users.noreply.github.com&gt;
diff --git a/test/OpenApiKiotaEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs b/test/OpenApiKiotaEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs
@@ -27,7 +27,9 @@ public ModelStateValidationTests(IntegrationTestContext<OpenApiStartup<ModelStat
         _requestAdapterFactory = new TestableHttpClientRequestAdapterFactory(testOutputHelper);
 
         testContext.UseController<SocialMediaAccountsController>();
-        testContext.Factory.Services.GetRequiredService<IJsonApiOptions>().SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());
+
+        var options = testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
+        options.SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());
     }
 
     [Theory]
diff --git a/test/OpenApiNSwagEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs b/test/OpenApiNSwagEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs
@@ -26,7 +26,9 @@ public ModelStateValidationTests(IntegrationTestContext<OpenApiStartup<ModelStat
         _logHttpMessageHandler = new XUnitLogHttpMessageHandler(testOutputHelper);
 
         testContext.UseController<SocialMediaAccountsController>();
-        testContext.Factory.Services.GetRequiredService<IJsonApiOptions>().SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());
+
+        var options = testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();
+        options.SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());
     }
 
     [Theory]
diff --git a/test/OpenApiTests/ModelStateValidation/ModelStateValidationFakers.cs b/test/OpenApiTests/ModelStateValidation/ModelStateValidationFakers.cs
@@ -32,7 +32,7 @@ public sealed class ModelStateValidationFakers
         .RuleFor(socialMediaAccount => socialMediaAccount.NextRevalidation, faker => TimeSpan.FromHours(faker.Random.Number(1, 5)))
         .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAt, faker => faker.Date.Recent().ToUniversalTime().TruncateToWholeMilliseconds())
         .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtDate, faker => DateOnly.FromDateTime(faker.Date.Recent()))
-        .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtTime, faker => TimeOnly.FromDateTime(faker.Date.Recent())));
+        .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtTime, faker => TimeOnly.FromDateTime(faker.Date.Recent().TruncateToWholeMilliseconds())));
 
     public Faker<SocialMediaAccount> SocialMediaAccount => _lazySocialMediaAccountFaker.Value;
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,9 @@ public ModelStateValidationTests(IntegrationTestContext<OpenApiStartup<ModelStat`
`27`	`27`	`_requestAdapterFactory = new TestableHttpClientRequestAdapterFactory(testOutputHelper);`
`28`	`28`
`29`	`29`	`testContext.UseController<SocialMediaAccountsController>();`
`30`		`- testContext.Factory.Services.GetRequiredService<IJsonApiOptions>().SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());`
	`30`	`+`
	`31`	`+ var options = testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();`
	`32`	`+ options.SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());`
`31`	`33`	`}`
`32`	`34`
`33`	`35`	`[Theory]`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,9 @@ public ModelStateValidationTests(IntegrationTestContext<OpenApiStartup<ModelStat`
`26`	`26`	`_logHttpMessageHandler = new XUnitLogHttpMessageHandler(testOutputHelper);`
`27`	`27`
`28`	`28`	`testContext.UseController<SocialMediaAccountsController>();`
`29`		`- testContext.Factory.Services.GetRequiredService<IJsonApiOptions>().SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());`
	`29`	`+`
	`30`	`+ var options = testContext.Factory.Services.GetRequiredService<IJsonApiOptions>();`
	`31`	`+ options.SerializerOptions.Converters.Add(new UtcDateTimeJsonConverter());`
`30`	`32`	`}`
`31`	`33`
`32`	`34`	`[Theory]`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public sealed class ModelStateValidationFakers`
`32`	`32`	`.RuleFor(socialMediaAccount => socialMediaAccount.NextRevalidation, faker => TimeSpan.FromHours(faker.Random.Number(1, 5)))`
`33`	`33`	`.RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAt, faker => faker.Date.Recent().ToUniversalTime().TruncateToWholeMilliseconds())`
`34`	`34`	`.RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtDate, faker => DateOnly.FromDateTime(faker.Date.Recent()))`
`35`		`- .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtTime, faker => TimeOnly.FromDateTime(faker.Date.Recent())));`
	`35`	`+ .RuleFor(socialMediaAccount => socialMediaAccount.ValidatedAtTime, faker => TimeOnly.FromDateTime(faker.Date.Recent().TruncateToWholeMilliseconds())));`
`36`	`36`
`37`	`37`	`public Faker<SocialMediaAccount> SocialMediaAccount => _lazySocialMediaAccountFaker.Value;`
`38`	`38`	`}`