Skip to content

Commit 42a010a

Browse files
authored
Replace DOTNET_SKIP_FIRST_TIME_EXPERIENCE with DOTNET_NOLOGO (#1692)
* Replace DOTNET_SKIP_FIRST_TIME_EXPERIENCE with DOTNET_NOLOGO * Fix broken build on .NET SDK v9.0.200
1 parent 7eec5ca commit 42a010a

File tree

3 files changed

+16
-8
lines changed

3 files changed

+16
-8
lines changed

.editorconfig

+8
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,12 @@ csharp_style_expression_bodied_properties = true:silent
113113
# IDE0025: Use expression body for properties
114114
dotnet_diagnostic.IDE0025.severity = silent
115115

116+
# Member preferences (these analyzers are unreliable)
117+
# IDE0051: Remove unused private member
118+
dotnet_diagnostic.IDE0051.severity = silent
119+
# IDE0052: Remove unread private member
120+
dotnet_diagnostic.IDE0052.severity = silent
121+
116122
# Code-block preferences
117123
csharp_prefer_braces = true:silent
118124
# IDE0011: Add braces
@@ -142,11 +148,13 @@ dotnet_diagnostic.IDE0047.severity = silent
142148
# IDE0048: Add parentheses for clarity
143149
dotnet_diagnostic.IDE0048.severity = silent
144150

151+
# Switch preferences
145152
# IDE0010: Add missing cases to switch statement
146153
dotnet_diagnostic.IDE0010.severity = silent
147154
# IDE0072: Add missing cases to switch expression
148155
dotnet_diagnostic.IDE0072.severity = silent
149156

157+
# Null check preferences
150158
# IDE0029: Null check can be simplified
151159
dotnet_diagnostic.IDE0029.severity = silent
152160
# IDE0030: Null check can be simplified

.github/workflows/build.yml

+7-7
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ concurrency:
2121
cancel-in-progress: true
2222

2323
env:
24-
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: true
24+
DOTNET_NOLOGO: true
2525
DOTNET_CLI_TELEMETRY_OPTOUT: true
2626

2727
jobs:
@@ -47,8 +47,8 @@ jobs:
4747
with:
4848
# Block buggy release from February 11, 2025
4949
dotnet-version: |
50-
8.0.309
51-
9.0.103
50+
8.0.*
51+
9.0.*
5252
- name: Show installed versions
5353
shell: pwsh
5454
run: |
@@ -166,8 +166,8 @@ jobs:
166166
with:
167167
# Block buggy release from February 11, 2025
168168
dotnet-version: |
169-
8.0.309
170-
9.0.103
169+
8.0.*
170+
9.0.*
171171
- name: Git checkout
172172
uses: actions/checkout@v4
173173
- name: Restore tools
@@ -222,8 +222,8 @@ jobs:
222222
with:
223223
# Block buggy release from February 11, 2025
224224
dotnet-version: |
225-
8.0.309
226-
9.0.103
225+
8.0.*
226+
9.0.*
227227
- name: Git checkout
228228
uses: actions/checkout@v4
229229
with:

Directory.Build.props

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
Taking the suggestion TODAY produces List<string>, but the spec doesn't require that, so the compiler may change it over time.
2323
As a result, callers that cast back to List<string> will face a breaking change.
2424
-->
25-
<UseCollectionExpressionRules>IDE0028;IDE0300;IDE0301;IDE0302;IDE0303;IDE0304;IDE0305</UseCollectionExpressionRules>
25+
<UseCollectionExpressionRules>IDE0028;IDE0300;IDE0301;IDE0302;IDE0303;IDE0304;IDE0305;IDE0306</UseCollectionExpressionRules>
2626
<NoWarn>$(NoWarn);$(UseCollectionExpressionRules)</NoWarn>
2727

2828
<!-- Suppress warning that targeting .NET Standard 1.0 is not recommended, because it requires a breaking change. -->

0 commit comments

Comments
 (0)