stuff

Author: verdie-g

test/OpenApiNSwagEndToEndTests/ModelStateValidation/ModelStateValidationTests.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using FluentAssertions;
 using JsonApiDotNetCore.OpenApi.Client.NSwag;
 using OpenApiNSwagEndToEndTests.ModelStateValidation.GeneratedCode;
@@ -200,7 +201,7 @@ public async Task Cannot_use_invalid_credit_card_number()
     }
 
     [Fact]
-    public async Task Cannot_use_invalid_email()
+    public async Task Cannot_use_invalid_email_address()
     {
         // Arrange
         SocialMediaAccount socialMediaAccount = _fakers.SocialMediaAccount.Generate();
@@ -426,7 +427,7 @@ public async Task Cannot_use_TimeSpan_outside_of_valid_range()
                 Attributes = new SocialMediaAccountAttributesInPostRequest
                 {
                     LastName = socialMediaAccount.LastName,
-                    NextRevalidation = "00:00:01",
+                    NextRevalidation = TimeSpan.FromSeconds(1).ToString()
                 }
             }
         };
@@ -443,6 +444,40 @@ public async Task Cannot_use_TimeSpan_outside_of_valid_range()
         errorObject.Source.Pointer.Should().Be("/data/attributes/nextRevalidation");
     }
 
+    [Fact]
+    public async Task Cannot_use_culture_sensitive_TimeSpan()
+    {
+        // Arrange
+        SocialMediaAccount socialMediaAccount = _fakers.SocialMediaAccount.Generate();
+
+        using HttpClient httpClient = _testContext.Factory.CreateDefaultClient(_logHttpMessageHandler);
+        ModelStateValidationClient apiClient = new(httpClient);
+
+        // Act
+        SocialMediaAccountPostRequestDocument requestBody = new()
+        {
+            Data = new SocialMediaAccountDataInPostRequest
+            {
+                Attributes = new SocialMediaAccountAttributesInPostRequest
+                {
+                    LastName = socialMediaAccount.LastName,
+                    NextRevalidation = new TimeSpan(0, 2, 0, 0, 1).ToString("g", new CultureInfo("fr-FR"))
+                }
+            }
+        };
+        Func<Task<SocialMediaAccountPrimaryResponseDocument>> action = () => apiClient.PostSocialMediaAccountAsync(requestBody);
+
+        // Assert
+        ErrorResponseDocument document = (await action.Should().ThrowExactlyAsync<ApiException<ErrorResponseDocument>>()).Which.Result;
+        document.Errors.ShouldHaveCount(1);
+
+        ErrorObject errorObject = document.Errors.First();
+        errorObject.Title.Should().Be("Failed to deserialize request body: Incompatible attribute value found.");
+        errorObject.Detail.Should().Be("Failed to convert attribute 'nextRevalidation' with value '2:00:00,001' of type 'String' to type 'Nullable<TimeSpan>'.");
+        errorObject.Source.ShouldNotBeNull();
+        errorObject.Source.Pointer.Should().Be("/data/attributes/nextRevalidation");
+    }
+
     [Fact]
     public async Task Cannot_use_invalid_TimeOnly()
     {

test/OpenApiTests/ModelStateValidation/ModelStateValidationFakers.cs

@@ -16,10 +16,9 @@ public sealed class ModelStateValidationFakers
         .RuleFor(socialMediaAccount => socialMediaAccount.FirstName, faker => faker.Person.FirstName)
         .RuleFor(socialMediaAccount => socialMediaAccount.GivenName, (_, socialMediaAccount) => socialMediaAccount.FirstName)
         .RuleFor(socialMediaAccount => socialMediaAccount.LastName, faker => faker.Person.LastName)
-        .RuleFor(socialMediaAccount => socialMediaAccount.UserName, faker => faker.Person.UserName)
+        .RuleFor(socialMediaAccount => socialMediaAccount.UserName, faker => faker.Random.String2(3, 18))
         .RuleFor(socialMediaAccount => socialMediaAccount.CreditCard, faker => faker.Finance.CreditCardNumber())
         .RuleFor(socialMediaAccount => socialMediaAccount.Email, faker => faker.Person.Email)
-        .RuleFor(socialMediaAccount => socialMediaAccount.Password, faker => faker.Random.String2(8, 32))
         .RuleFor(socialMediaAccount => socialMediaAccount.Password, faker => Convert.ToBase64String(faker.Random.Bytes(20)))
         .RuleFor(socialMediaAccount => socialMediaAccount.Phone, faker => faker.Person.Phone)
         .RuleFor(socialMediaAccount => socialMediaAccount.Age, faker => faker.Random.Double(0.1, 122.9))