Disallow decorating private-named properties

Disallow decorating private-named properties
because the spec is still in flux.

Signed-off-by: Max Heiber <[email protected]>

Author: Max Heiber

src/compiler/utilities.ts

@@ -1498,7 +1498,7 @@ namespace ts {
     export function nodeCanBeDecorated(node: Node, parent: Node, grandparent: Node): boolean;
     export function nodeCanBeDecorated(node: Node, parent?: Node, grandparent?: Node): boolean {
         // private names cannot be used with decorators yet
-        if (isNamedDeclaration(node) && node.name.kind === SyntaxKind.PrivateName) {
+        if (isNamedDeclaration(node) && isPrivateName(node.name)) {
             return false;
         }
         switch (node.kind) {
@@ -1514,8 +1514,8 @@ namespace ts {
             case SyntaxKind.SetAccessor:
             case SyntaxKind.MethodDeclaration:
                 // if this method has a body and its parent is a class declaration, this is a valid target.
-                return (node as FunctionLikeDeclaration).body !== undefined
-                    && parent!.kind === SyntaxKind.ClassDeclaration
+                return (<FunctionLikeDeclaration>node).body !== undefined
+                    && parent!.kind === SyntaxKind.ClassDeclaration;
 
             case SyntaxKind.Parameter:
                 // if the parameter's parent has a body and its grandparent is a class declaration, this is a valid target;

tests/baselines/reference/privateNamesAndDecorators.errors.txt

@@ -6,11 +6,11 @@ tests/cases/conformance/classes/members/privateNames/privateNamesAndDecorators.t
     declare function dec<T>(target: T): T;
 
     class A {
-        @dec
+        @dec                // Error
         ~
 !!! error TS1206: Decorators are not valid here.
         #foo = 1;
-        @dec
+        @dec                // Error
         ~
 !!! error TS1206: Decorators are not valid here.
         #bar(): void { }

tests/baselines/reference/privateNamesAndDecorators.js

@@ -2,9 +2,9 @@
 declare function dec<T>(target: T): T;
 
 class A {
-    @dec
+    @dec                // Error
     #foo = 1;
-    @dec
+    @dec                // Error
     #bar(): void { }
 }
 

tests/baselines/reference/privateNamesAndDecorators.symbols

@@ -9,13 +9,13 @@ declare function dec<T>(target: T): T;
 class A {
 >A : Symbol(A, Decl(privateNamesAndDecorators.ts, 0, 38))
 
-    @dec
+    @dec                // Error
 >dec : Symbol(dec, Decl(privateNamesAndDecorators.ts, 0, 0))
 
     #foo = 1;
 >#foo : Symbol(A.#foo, Decl(privateNamesAndDecorators.ts, 2, 9))
 
-    @dec
+    @dec                // Error
 >dec : Symbol(dec, Decl(privateNamesAndDecorators.ts, 0, 0))
 
     #bar(): void { }

tests/baselines/reference/privateNamesAndDecorators.types

@@ -6,14 +6,14 @@ declare function dec<T>(target: T): T;
 class A {
 >A : A
 
-    @dec
+    @dec                // Error
 >dec : <T>(target: T) => T
 
     #foo = 1;
 >#foo : number
 >1 : 1
 
-    @dec
+    @dec                // Error
 >dec : <T>(target: T) => T
 
     #bar(): void { }

tests/cases/conformance/classes/members/privateNames/privateNamesAndDecorators.ts

@@ -1,8 +1,8 @@
 declare function dec<T>(target: T): T;
 
 class A {
-    @dec
+    @dec                // Error
     #foo = 1;
-    @dec
+    @dec                // Error
     #bar(): void { }
 }