Correctly resolve tags for function overloads. Fixes microsoft#30181

Author: jeanp413

src/services/symbolDisplay.ts

@@ -135,6 +135,7 @@ namespace ts.SymbolDisplay {
         let printer: Printer;
         let documentationFromAlias: SymbolDisplayPart[] | undefined;
         let tagsFromAlias: JSDocTagInfo[] | undefined;
+        let signature: Signature | undefined;
 
         if (location.kind === SyntaxKind.ThisKeyword && !isThisExpression) {
             return { displayParts: [keywordPart(SyntaxKind.ThisKeyword)], documentation: [], symbolKind: ScriptElementKind.primitiveType, tags: undefined };
@@ -147,7 +148,6 @@ namespace ts.SymbolDisplay {
                 symbolKind = ScriptElementKind.memberVariableElement;
             }
 
-            let signature: Signature | undefined;
             type = isThisExpression ? typeChecker.getTypeAtLocation(location) : typeChecker.getTypeOfSymbolAtLocation(symbol.exportSymbol || symbol, location);
 
             if (location.parent && location.parent.kind === SyntaxKind.PropertyAccessExpression) {
@@ -501,7 +501,7 @@ namespace ts.SymbolDisplay {
 
         if (!documentation) {
             documentation = symbol.getDocumentationComment(typeChecker);
-            tags = symbol.getJsDocTags();
+            tags = signature ? signature.getJsDocTags() : symbol.getJsDocTags();
             if (documentation.length === 0 && symbolFlags & SymbolFlags.Property) {
                 // For some special property access expressions like `exports.foo = foo` or `module.exports.foo = foo`
                 // there documentation comments might be attached to the right hand side symbol of their declarations.

tests/cases/fourslash/quickInfoJsDocTagsFunctionOverload.ts

@@ -0,0 +1,62 @@
+/// <reference path='fourslash.ts'/>
+
+// @Filename: quickInfoJsDocTagsFunctionOverload.ts
+////declare function /*1*/foo(): void;
+////
+/////**
+//// * @tag Tag text
+//// */
+////declare function /*2*/foo(x: number): void
+
+goTo.marker("1");
+verify.verifyQuickInfoDisplayParts(
+    "function",
+    "declare",
+    { start: 17, length: 3 },
+    [
+        {text:"function",kind:"keyword"},
+        {text:" ",kind:"space"},
+        {text:"foo",kind:"functionName"},
+        {text:"(",kind:"punctuation"},
+        {text:")",kind:"punctuation"},
+        {text:":",kind:"punctuation"},
+        {text:" ",kind:"space"},
+        {text:"void",kind:"keyword"},
+        {text:" ",kind:"space"},
+        {text:"(",kind:"punctuation"},
+        {text:"+",kind:"operator"},
+        {text:"1",kind:"numericLiteral"},
+        {text:" ",kind:"space"},
+        {text:"overload",kind:"text"},
+        {text:")",kind:"punctuation"}
+    ],
+    []);
+
+goTo.marker("2");
+verify.verifyQuickInfoDisplayParts(
+    "function",
+    "declare",
+    { start: 73, length: 3 },
+    [
+        {text:"function",kind:"keyword"},
+        {text:" ",kind:"space"},
+        {text:"foo",kind:"functionName"},
+        {text:"(",kind:"punctuation"},
+        {text:"x",kind:"parameterName"},
+        {text:":",kind:"punctuation"},
+        {text:" ",kind:"space"},
+        {text:"number",kind:"keyword"},
+        {text:")",kind:"punctuation"},
+        {text:":",kind:"punctuation"},
+        {text:" ",kind:"space"},
+        {text:"void",kind:"keyword"},
+        {text:" ",kind:"space"},
+        {text:"(",kind:"punctuation"},
+        {text:"+",kind:"operator"},
+        {text:"1",kind:"numericLiteral"},
+        {text:" ",kind:"space"},
+        {text:"overload",kind:"text"},
+        {text:")",kind:"punctuation"}
+    ],
+    [],
+    [{ name: "tag", text: "Tag text" }]);