-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix links and improve clarity in PRNG documentation #33608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fix URL redirects
Summary of ChangesHello @partev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the accuracy and reliability of the project's documentation by updating a critical external reference. Specifically, it addresses a broken link within the PRNG documentation, ensuring that users can seamlessly access the referenced research paper without encountering redirect errors or insecure connections. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates several HTTP links to HTTPS in the PRNG documentation, which is a good improvement for security and to avoid redirects. I've added a few suggestions to update another link to its more persistent DOI version.
While this PR focuses on documentation, I noticed that jax/random.py also contains http://www.thesalmons.org links that could be updated in a follow-up.
The changes in this PR are good. LGTM once the suggestions are addressed.
|
As long as you're regularizing URLs here, would you be willing to make the fixes suggested by the review bot? |
Yes, I will do later today |
fix ACM link redirect Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
fix ACM link redirects
@jakevdp I made the 3 proposed changes. The actual proposed changes were linking to a dead link, but I used the correct URL redirect. |
fix URL redirects
http://www.thesalmons.org/john/random123/papers/random123sc11.pdf -> https://thesalmons.org/john/random123/papers/random123sc11.pdf