Skip to content

Conversation

@partev
Copy link

@partev partev commented Dec 1, 2025

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @partev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining the accuracy and reliability of the project's documentation by updating a critical external reference. Specifically, it addresses a broken link within the PRNG documentation, ensuring that users can seamlessly access the referenced research paper without encountering redirect errors or insecure connections.

Highlights

  • Documentation Update: Updated an external link in the PRNG documentation from HTTP to HTTPS to resolve a redirect issue and ensure the link remains functional and secure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates several HTTP links to HTTPS in the PRNG documentation, which is a good improvement for security and to avoid redirects. I've added a few suggestions to update another link to its more persistent DOI version.

While this PR focuses on documentation, I noticed that jax/random.py also contains http://www.thesalmons.org links that could be updated in a follow-up.

The changes in this PR are good. LGTM once the suggestions are addressed.

@jakevdp
Copy link
Collaborator

jakevdp commented Dec 1, 2025

As long as you're regularizing URLs here, would you be willing to make the fixes suggested by the review bot?

@jakevdp jakevdp self-assigned this Dec 1, 2025
@partev
Copy link
Author

partev commented Dec 1, 2025

As long as you're regularizing URLs here, would you be willing to make the fixes suggested by the review bot?

Yes, I will do later today

partev and others added 2 commits December 1, 2025 22:03
fix ACM link redirect

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
fix ACM link redirects
@partev
Copy link
Author

partev commented Dec 2, 2025

As long as you're regularizing URLs here, would you be willing to make the fixes suggested by the review bot?

@jakevdp I made the 3 proposed changes. The actual proposed changes were linking to a dead link, but I used the correct URL redirect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants