Fixes microsoft#26122.

When `resolveCall` does not resolve in `resolveNewExpression`, the error should only be thrown if there is a *defined* signature that is not-void.

Author: jameskeane

src/compiler/checker.ts

@@ -19592,7 +19592,7 @@ namespace ts {
             const callSignatures = getSignaturesOfType(expressionType, SignatureKind.Call);
             if (callSignatures.length) {
                 const signature = resolveCall(node, callSignatures, candidatesOutArray, isForSignatureHelp);
-                if (!isJavaScriptConstructor(signature.declaration) && getReturnTypeOfSignature(signature) !== voidType) {
+                if (signature.declaration && !isJavaScriptConstructor(signature.declaration) && getReturnTypeOfSignature(signature) !== voidType) {
                     error(node, Diagnostics.Only_a_void_function_can_be_called_with_the_new_keyword);
                 }
                 if (getThisTypeOfSignature(signature) === voidType) {

tests/baselines/reference/constructorFunctions.errors.txt

@@ -1,8 +1,9 @@
 tests/cases/conformance/salsa/index.js(22,15): error TS2348: Value of type 'typeof C3' is not callable. Did you mean to include 'new'?
 tests/cases/conformance/salsa/index.js(30,15): error TS2348: Value of type 'typeof C4' is not callable. Did you mean to include 'new'?
+tests/cases/conformance/salsa/index.js(55,13): error TS2554: Expected 1 arguments, but got 0.
 
 
-==== tests/cases/conformance/salsa/index.js (2 errors) ====
+==== tests/cases/conformance/salsa/index.js (3 errors) ====
     function C1() {
         if (!(this instanceof C1)) return new C1();
         this.x = 1;
@@ -53,4 +54,15 @@ tests/cases/conformance/salsa/index.js(30,15): error TS2348: Value of type 'type
     };
 
     var c6_v1 = new C6();
+    
+    
+    /**
+     * @constructor
+     * @param {number} num
+     */
+    function C7(num) {}
+    
+    var c7_v1 = new C7();
+                ~~~~~~~~
+!!! error TS2554: Expected 1 arguments, but got 0.
 

tests/baselines/reference/constructorFunctions.symbols

@@ -116,3 +116,16 @@ var c6_v1 = new C6();
 >c6_v1 : Symbol(c6_v1, Decl(index.js, 45, 3))
 >C6 : Symbol(C6, Decl(index.js, 38, 12))
 
+
+/**
+ * @constructor
+ * @param {number} num
+ */
+function C7(num) {}
+>C7 : Symbol(C7, Decl(index.js, 45, 21))
+>num : Symbol(num, Decl(index.js, 52, 12))
+
+var c7_v1 = new C7();
+>c7_v1 : Symbol(c7_v1, Decl(index.js, 54, 3))
+>C7 : Symbol(C7, Decl(index.js, 45, 21))
+

tests/baselines/reference/constructorFunctions.types

@@ -168,3 +168,17 @@ var c6_v1 = new C6();
 >new C6() : C6
 >C6 : typeof C6
 
+
+/**
+ * @constructor
+ * @param {number} num
+ */
+function C7(num) {}
+>C7 : typeof C7
+>num : number
+
+var c7_v1 = new C7();
+>c7_v1 : any
+>new C7() : any
+>C7 : typeof C7
+

tests/baselines/reference/instantiateNonGenericTypeWithTypeArguments.errors.txt

@@ -1,12 +1,10 @@
 tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(8,15): error TS2558: Expected 0 type arguments, but got 1.
-tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(11,9): error TS2350: Only a void function can be called with the 'new' keyword.
 tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(11,17): error TS2558: Expected 0 type arguments, but got 1.
-tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(14,10): error TS2350: Only a void function can be called with the 'new' keyword.
 tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(14,16): error TS2558: Expected 0 type arguments, but got 1.
 tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts(18,10): error TS2347: Untyped function calls may not accept type arguments.
 
 
-==== tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts (6 errors) ====
+==== tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGenericTypeWithTypeArguments.ts (4 errors) ====
     // it is an error to provide type arguments to a non-generic call
     // all of these are errors
 
@@ -20,15 +18,11 @@ tests/cases/conformance/types/typeParameters/typeArgumentLists/instantiateNonGen
 
     function Foo(): void { }
     var r = new Foo<number>();
-            ~~~~~~~~~~~~~~~~~
-!!! error TS2350: Only a void function can be called with the 'new' keyword.
                     ~~~~~~
 !!! error TS2558: Expected 0 type arguments, but got 1.
 
     var f: { (): void };
     var r2 = new f<number>();
-             ~~~~~~~~~~~~~~~
-!!! error TS2350: Only a void function can be called with the 'new' keyword.
                    ~~~~~~
 !!! error TS2558: Expected 0 type arguments, but got 1.
 

tests/cases/conformance/salsa/constructorFunctions.ts

@@ -49,3 +49,12 @@ function C6() {
 };
 
 var c6_v1 = new C6();
+
+
+/**
+ * @constructor
+ * @param {number} num
+ */
+function C7(num) {}
+
+var c7_v1 = new C7();