Skip to content

Commit 9028920

Browse files
committed
Remove instrumenter
This infrastructure is used to create new RWC tests by making an "instrumented" tsc executable that outputs IO information. Per internal discussion, we don't think we need this sort of thing anymore, so remove it rather than try to make it work. If we wanted to make it work, I'd add a new entrypoint to the tsc project which calls the logged IO code directly, which matches what the old source-level modification script tacked onto the real tsc.
1 parent edb57ce commit 9028920

File tree

4 files changed

+0
-101
lines changed

4 files changed

+0
-101
lines changed

Gulpfile.js

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -567,23 +567,6 @@ task("baseline-accept").description = "Makes the most recent test results the ne
567567
task("baseline-accept-rwc", () => baselineAccept(localRwcBaseline, refRwcBaseline));
568568
task("baseline-accept-rwc").description = "Makes the most recent rwc test results the new baseline, overwriting the old baseline";
569569

570-
// TODO(jakebailey): figure out what tsc-instrumented and such are for and what do to with them.
571-
572-
const buildLoggedIO = () => buildProject("src/loggedIO/tsconfig-tsc-instrumented.json");
573-
const cleanLoggedIO = () => del("built/local/loggedIO.js");
574-
cleanTasks.push(cleanLoggedIO);
575-
576-
const buildInstrumenter = () => buildProject("src/instrumenter");
577-
const cleanInstrumenter = () => cleanProject("src/instrumenter");
578-
cleanTasks.push(cleanInstrumenter);
579-
580-
const tscInstrumented = () => exec(process.execPath, ["built/local/instrumenter.js", "record", cmdLineOptions.tests || "iocapture", "built/local/tsc.js"]);
581-
task("tsc-instrumented", series(lkgPreBuild, parallel(localize, buildTsc, buildServer, buildServices, buildLssl, buildLoggedIO, buildInstrumenter), tscInstrumented));
582-
task("tsc-instrumented").description = "Builds an instrumented tsc.js";
583-
task("tsc-instrumented").flags = {
584-
"-t --tests=<testname>": "The test to run."
585-
};
586-
587570
// TODO(rbuckton): Determine if we still need this task. Depending on a relative
588571
// path here seems like a bad idea.
589572
const updateSublime = () => src(["built/local/tsserver.js", "built/local/tsserver.js.map"])

src/instrumenter/instrumenter.ts

Lines changed: 0 additions & 43 deletions
This file was deleted.

src/instrumenter/tsconfig.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/loggedIO/tsconfig-tsc-instrumented.json

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)