Clean up

Author: julieg18

extension/src/pipeline/quickPick.ts

@@ -46,10 +46,11 @@ const formatFieldQuickPickValues = (
     }
 
     const prevFileValue = formattedFields[file]
-    formattedFields[file] = [
-      ...(typeof prevFileValue === 'string' ? [prevFileValue] : prevFileValue),
-      key
-    ]
+    if (typeof prevFileValue === 'string') {
+      formattedFields[file] = [prevFileValue]
+    }
+
+    ;(formattedFields[file] as string[]).push(key)
   }
 
   return formattedFields

extension/src/test/suite/pipeline/index.test.ts

@@ -309,12 +309,14 @@ suite('Pipeline Test Suite', () => {
     expect(mockPickPlotConfiguration).to.be.calledOnce
     expect(mockAddPlotToDvcFile).not.to.be.called
 
-    mockPickPlotConfiguration.onSecondCall().resolves({
+    const mockPlotConfig: PipelineQuickPick.PlotConfigData = {
       template: 'simple',
       title: 'Great Plot Name',
-      x: { file: 'results.json', key: 'step' },
+      x: { 'results.json': 'step' },
       y: { 'results.json': 'acc' }
-    })
+    }
+
+    mockPickPlotConfiguration.onSecondCall().resolves(mockPlotConfig)
 
     await pipeline.addDataSeriesPlot()