Separate input and output directory settings (#395)

0x2b3bfa0 · casperdcl · web-flow · commit ed322f3b4c33 · 2022-02-21T18:24:12.000Z
Co-authored-by: Casper da Costa-Luis &lt;casper.dcl@physics.org&gt;
diff --git a/docs/guides/getting-started.md b/docs/guides/getting-started.md
@@ -27,6 +27,7 @@ resource "iterative_task" "task" {
 
   workdir {
     input = "${path.root}/shared"
+    output = "${path.root}/shared"
   }
   script = <<-END
     #!/bin/bash
diff --git a/docs/resources/task.md b/docs/resources/task.md
@@ -42,7 +42,7 @@ resource "iterative_task" "task" {
 - `image` - (Optional) [Machine image](#machine-images) to run the task with.
 - `parallelism` - (Optional) Number of machines to be launched in parallel.
 - `workdir.input` - (Optional) Local working directory to upload.
-- `workdir.output` - (Optional) Local directory to download results to (default: `workdir.input`).
+- `workdir.output` - (Optional) Local directory to download results to (default: no download).
 - `environment` - (Optional) Map of environment variable names and values for the task script. Empty string values are replaced with local environment values. Empty values may also be combined with a [glob](<https://en.wikipedia.org/wiki/Glob_(programming)>) name to import all matching variables.
 - `timeout` - (Optional) Maximum number of seconds to run before termination.
 
diff --git a/iterative/resource_task.go b/iterative/resource_task.go
@@ -292,9 +292,6 @@ func resourceTaskBuild(ctx context.Context, d *schema.ResourceData, m interface{
 			return nil, errors.New("output directory " + directory_out + " is not empty!")
 		}
 	}
-	if directory_out == "" {
-		directory_out = directory
-	}
 
 	t := common.Task{
 		Size: common.Size{

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ resource "iterative_task" "task" {`
`27`	`27`
`28`	`28`	`workdir {`
`29`	`29`	`input = "${path.root}/shared"`
	`30`	`+ output = "${path.root}/shared"`
`30`	`31`	`}`
`31`	`32`	`script = <<-END`
`32`	`33`	`#!/bin/bash`
Original file line number	Diff line number	Diff line change
`@@ -292,9 +292,6 @@ func resourceTaskBuild(ctx context.Context, d *schema.ResourceData, m interface{`
`292`	`292`	`return nil, errors.New("output directory " + directory_out + " is not empty!")`
`293`	`293`	`}`
`294`	`294`	`}`
`295`		`- if directory_out == "" {`
`296`		`- directory_out = directory`
`297`		`- }`
`298`	`295`
`299`	`296`	`t := common.Task{`
`300`	`297`	`Size: common.Size{`