Skip to content

deprecation of fsspec_loop in fsspec #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtrifiro opened this issue Dec 20, 2022 · 0 comments · Fixed by #28
Closed

deprecation of fsspec_loop in fsspec #24

dtrifiro opened this issue Dec 20, 2022 · 0 comments · Fixed by #28
Assignees
@dtrifiro

Comments

@dtrifiro
Copy link
Contributor

With fsspec/filesystem_spec#1134, fsspec gets rid of the fsspec_loop context manager, which is used by prepare_credentials to set up the TCPConnector:

dvc-http/dvc_http/__init__.py

Lines 84 to 87 in 15395d1

with fsspec_loop():
client_kwargs["connector"] = aiohttp.TCPConnector(
**connector_kwargs
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtrifiro dtrifiro

Labels
None yet
Projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

_prepare_credentials: connector fix for fsspec>=2022.12 iterative/dvc-http
1 participant
@dtrifiro