use 'algebraicTyCon' as filter for now

Author: WorldSEnder

plugins/tactics/src/Ide/Plugin/Tactic.hs

@@ -21,7 +21,6 @@ import           Control.Monad.Trans.Maybe
 import           Data.Aeson
 import           Data.Coerce
 import qualified Data.Foldable as F
-import qualified Data.List as L
 import qualified Data.Map as M
 import           Data.Maybe
 import qualified Data.Set as S
@@ -38,7 +37,7 @@ import           Development.Shake (Action)
 import           DynFlags (xopt)
 import qualified FastString
 import           GHC.Generics (Generic)
-import           GHC.LanguageExtensions.Type (Extension (LambdaCase, MagicHash))
+import           GHC.LanguageExtensions.Type (Extension (LambdaCase))
 import           Ide.Plugin (mkLspCommand)
 import           Ide.Plugin.Tactic.Context
 import           Ide.Plugin.Tactic.GHC
@@ -95,10 +94,9 @@ commandProvider Intros =
   filterGoalType isFunction $
     provide Intros ""
 commandProvider Split =
-  foldMapGoalType (F.fold . tyDataCons) $ \dc ->
-    let cname = occNameString $ getOccName dc
-    in  requireExtensionWhen MagicHash ("#" `L.isSuffixOf` cname) $
-      provide Split $ T.pack cname
+  filterGoalType (isJust . algebraicTyCon) $
+    foldMapGoalType (F.fold . tyDataCons) $ \dc ->
+      provide Split $ T.pack $ occNameString $ getOccName dc
 commandProvider Destruct =
   filterBindingType destructFilter $ \occ _ ->
     provide Destruct $ T.pack $ occNameString occ
@@ -193,13 +191,6 @@ requireExtension ext tp dflags plId uri range jdg =
     False -> pure []
 
 
-------------------------------------------------------------------------------
--- | Like 'requireExtension' but only check if the bool is @True@.
-requireExtensionWhen :: Extension -> Bool -> TacticProvider -> TacticProvider
-requireExtensionWhen ext True = requireExtension ext
-requireExtensionWhen _ False = id
-
-
 ------------------------------------------------------------------------------
 -- | Create a 'TacticProvider' for each occurance of an 'a' in the foldable container
 -- extracted from the goal type. Useful instantiations for 't' include 'Maybe' or '[]'.

test/functional/Tactic.hs

@@ -21,6 +21,7 @@ import           Language.Haskell.LSP.Types (ApplyWorkspaceEditRequest, Position
 import           Test.Hls.Util
 import           Test.Tasty
 import           Test.Tasty.HUnit
+import Test.Tasty.ExpectedFailure (ignoreTestBecause)
 import           System.FilePath
 import System.Directory (doesFileExist)
 import Control.Monad (unless)
@@ -80,8 +81,8 @@ tests = testGroup
       "T3.hs" 7 13
       [ (id, DestructLambdaCase, "")
       ]
-  , mkTest
-      "Produces I# with -XMagicHash"
+  , ignoreTestBecause "Not implemented, see #31" $ mkTest
+      "Splits Int with I# when -XMagicHash is enabled"
       "T3.hs" 10 14
       [ (id, Split, "I#")
       ]