Skip to content

Commit bca92b1

Browse files
authored
[bazel] Allow SupportTests to be built remotely and cached (llvm#121375)
`SupportTests` fails in the bazel macOS sandbox, because `FileSystemTest.permissions` expects to be able to modify file permissions on some otherwise protected files. Previously this test was marked `local` in bazel, which has additional undesirable effects such as skipping remote build and cache. Tighten the bazel tags to just `no-sandbox`. Note in particular, that this allows the test to build, execute, and cache remotely (if configured). Testing: - Verified this test fails (as expected) on macOS with no tags, and passes with `no-sandbox`. - Verified this test passes when executed remotely (using an Engflow RBE setup) with `no-sandbox`.
1 parent 5de7af4 commit bca92b1

File tree

1 file changed

+1
-1
lines changed
  • utils/bazel/llvm-project-overlay/llvm/unittests

1 file changed

+1
-1
lines changed

utils/bazel/llvm-project-overlay/llvm/unittests/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ cc_test(
697697
],
698698
linkstatic = 1,
699699
tags = [
700-
"local", # Not compatible with the sandbox on MacOS
700+
"no-sandbox", # FileSystemTest.permissions not compatible with the sandbox on MacOS
701701
],
702702
deps = [
703703
"//llvm:AllTargetsCodeGens",

0 commit comments

Comments
 (0)