From 0e2339fb10b4ba5a36c1e833b04fe29aa399b237 Mon Sep 17 00:00:00 2001
From: b-ma <benjamin.matuszewski@gmail.com>
Date: Wed, 6 Dec 2023 10:04:56 +0100
Subject: [PATCH 1/2] wip: fix clippy complains

---
 generator/templates/audio_context.tmpl.rs |  8 ++++----
 generator/templates/audio_param.tmpl.rs   | 16 ++++++++--------
 src/audio_context.rs                      | 10 ++++------
 src/audio_param.rs                        | 16 ++++++++--------
 src/offline_audio_context.rs              |  4 +---
 5 files changed, 25 insertions(+), 29 deletions(-)

diff --git a/generator/templates/audio_context.tmpl.rs b/generator/templates/audio_context.tmpl.rs
index 5cbc7d83..f31f940f 100644
--- a/generator/templates/audio_context.tmpl.rs
+++ b/generator/templates/audio_context.tmpl.rs
@@ -92,7 +92,7 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                     }
                 }
                 Either::B(js_number) => {
-                    let latency = js_number.get_double()? as f64;
+                    let latency = js_number.get_double()?;
                     AudioContextLatencyCategory::Custom(latency)
                 }
             }
@@ -170,7 +170,7 @@ fn get_current_time(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let current_time = obj.current_time() as f64;
+    let current_time = obj.current_time();
     ctx.env.create_double(current_time)
 }
 
@@ -384,7 +384,7 @@ fn get_base_latency(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let base_latency = obj.base_latency() as f64;
+    let base_latency = obj.base_latency();
     ctx.env.create_double(base_latency)
 }
 
@@ -394,7 +394,7 @@ fn get_output_latency(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let output_latency = obj.output_latency() as f64;
+    let output_latency = obj.output_latency();
     ctx.env.create_double(output_latency)
 }
 
diff --git a/generator/templates/audio_param.tmpl.rs b/generator/templates/audio_param.tmpl.rs
index a112741c..af14cbe5 100644
--- a/generator/templates/audio_param.tmpl.rs
+++ b/generator/templates/audio_param.tmpl.rs
@@ -80,7 +80,7 @@ fn linear_ramp_to_value_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let end_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
+    let end_time = ctx.get::<JsNumber>(1)?.get_double()?;
     obj.linear_ramp_to_value_at_time(value, end_time);
 
     ctx.env.get_undefined()
@@ -93,7 +93,7 @@ fn exponential_ramp_to_value_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let end_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
+    let end_time = ctx.get::<JsNumber>(1)?.get_double()?;
     obj.exponential_ramp_to_value_at_time(value, end_time);
 
     ctx.env.get_undefined()
@@ -108,8 +108,8 @@ fn set_value_curve_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let mut typed_array_values = ctx.get::<JsTypedArray>(0)?.into_value()?;
     let values: &mut [f32] = typed_array_values.as_mut();
 
-    let start_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
-    let duration = ctx.get::<JsNumber>(2)?.get_double()? as f64;
+    let start_time = ctx.get::<JsNumber>(1)?.get_double()?;
+    let duration = ctx.get::<JsNumber>(2)?.get_double()?;
     obj.set_value_curve_at_time(values, start_time, duration);
 
     ctx.env.get_undefined()
@@ -122,8 +122,8 @@ fn set_target_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let start_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
-    let time_constant = ctx.get::<JsNumber>(2)?.get_double()? as f64;
+    let start_time = ctx.get::<JsNumber>(1)?.get_double()?;
+    let time_constant = ctx.get::<JsNumber>(2)?.get_double()?;
     obj.set_target_at_time(value, start_time, time_constant);
 
     ctx.env.get_undefined()
@@ -135,7 +135,7 @@ fn cancel_scheduled_values(ctx: CallContext) -> Result<JsUndefined> {
     let napi_obj = ctx.env.unwrap::<NapiAudioParam>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()?;
     obj.cancel_scheduled_values(cancel_time);
 
     ctx.env.get_undefined()
@@ -147,7 +147,7 @@ fn cancel_and_hold_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let napi_obj = ctx.env.unwrap::<NapiAudioParam>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()?;
     obj.cancel_and_hold_at_time(cancel_time);
 
     ctx.env.get_undefined()
diff --git a/src/audio_context.rs b/src/audio_context.rs
index b0e1fedf..25c95923 100644
--- a/src/audio_context.rs
+++ b/src/audio_context.rs
@@ -104,7 +104,7 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                     }
                 }
                 Either::B(js_number) => {
-                    let latency = js_number.get_double()? as f64;
+                    let latency = js_number.get_double()?;
                     AudioContextLatencyCategory::Custom(latency)
                 }
             }
@@ -171,7 +171,7 @@ fn get_current_time(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<NapiAudioContext>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let current_time = obj.current_time() as f64;
+    let current_time = obj.current_time();
     ctx.env.create_double(current_time)
 }
 
@@ -192,10 +192,8 @@ fn get_listener(ctx: CallContext) -> Result<JsObject> {
 
     // reproduce lazy instanciation strategy from rust crate
     if js_this.has_named_property("__listener__").ok().unwrap() {
-        println!("reuse");
         js_this.get_named_property("__listener__")
     } else {
-        println!("wrap");
         let store_ref: &mut napi::Ref<()> = ctx.env.get_instance_data()?.unwrap();
         let store: JsObject = ctx.env.get_reference_value(store_ref)?;
         let ctor: JsFunction = store.get_named_property("AudioListener")?;
@@ -557,7 +555,7 @@ fn get_base_latency(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<NapiAudioContext>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let base_latency = obj.base_latency() as f64;
+    let base_latency = obj.base_latency();
     ctx.env.create_double(base_latency)
 }
 
@@ -567,7 +565,7 @@ fn get_output_latency(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<NapiAudioContext>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let output_latency = obj.output_latency() as f64;
+    let output_latency = obj.output_latency();
     ctx.env.create_double(output_latency)
 }
 
diff --git a/src/audio_param.rs b/src/audio_param.rs
index 3f9e4f61..163476ec 100644
--- a/src/audio_param.rs
+++ b/src/audio_param.rs
@@ -98,7 +98,7 @@ fn linear_ramp_to_value_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let end_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
+    let end_time = ctx.get::<JsNumber>(1)?.get_double()?;
     obj.linear_ramp_to_value_at_time(value, end_time);
 
     ctx.env.get_undefined()
@@ -111,7 +111,7 @@ fn exponential_ramp_to_value_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let end_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
+    let end_time = ctx.get::<JsNumber>(1)?.get_double()?;
     obj.exponential_ramp_to_value_at_time(value, end_time);
 
     ctx.env.get_undefined()
@@ -126,8 +126,8 @@ fn set_value_curve_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let mut typed_array_values = ctx.get::<JsTypedArray>(0)?.into_value()?;
     let values: &mut [f32] = typed_array_values.as_mut();
 
-    let start_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
-    let duration = ctx.get::<JsNumber>(2)?.get_double()? as f64;
+    let start_time = ctx.get::<JsNumber>(1)?.get_double()?;
+    let duration = ctx.get::<JsNumber>(2)?.get_double()?;
     obj.set_value_curve_at_time(values, start_time, duration);
 
     ctx.env.get_undefined()
@@ -140,8 +140,8 @@ fn set_target_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let obj = napi_obj.unwrap();
 
     let value = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-    let start_time = ctx.get::<JsNumber>(1)?.get_double()? as f64;
-    let time_constant = ctx.get::<JsNumber>(2)?.get_double()? as f64;
+    let start_time = ctx.get::<JsNumber>(1)?.get_double()?;
+    let time_constant = ctx.get::<JsNumber>(2)?.get_double()?;
     obj.set_target_at_time(value, start_time, time_constant);
 
     ctx.env.get_undefined()
@@ -153,7 +153,7 @@ fn cancel_scheduled_values(ctx: CallContext) -> Result<JsUndefined> {
     let napi_obj = ctx.env.unwrap::<NapiAudioParam>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()?;
     obj.cancel_scheduled_values(cancel_time);
 
     ctx.env.get_undefined()
@@ -165,7 +165,7 @@ fn cancel_and_hold_at_time(ctx: CallContext) -> Result<JsUndefined> {
     let napi_obj = ctx.env.unwrap::<NapiAudioParam>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let cancel_time = ctx.get::<JsNumber>(0)?.get_double()?;
     obj.cancel_and_hold_at_time(cancel_time);
 
     ctx.env.get_undefined()
diff --git a/src/offline_audio_context.rs b/src/offline_audio_context.rs
index bf306ccf..ef02b97b 100644
--- a/src/offline_audio_context.rs
+++ b/src/offline_audio_context.rs
@@ -115,7 +115,7 @@ fn get_current_time(ctx: CallContext) -> Result<JsNumber> {
     let napi_obj = ctx.env.unwrap::<NapiOfflineAudioContext>(&js_this)?;
     let obj = napi_obj.unwrap();
 
-    let current_time = obj.current_time() as f64;
+    let current_time = obj.current_time();
     ctx.env.create_double(current_time)
 }
 
@@ -136,10 +136,8 @@ fn get_listener(ctx: CallContext) -> Result<JsObject> {
 
     // reproduce lazy instanciation strategy from rust crate
     if js_this.has_named_property("__listener__").ok().unwrap() {
-        println!("reuse");
         js_this.get_named_property("__listener__")
     } else {
-        println!("wrap");
         let store_ref: &mut napi::Ref<()> = ctx.env.get_instance_data()?.unwrap();
         let store: JsObject = ctx.env.get_reference_value(store_ref)?;
         let ctor: JsFunction = store.get_named_property("AudioListener")?;

From c87a9281331697aff6f4a0e0450640bc8bcf8eb0 Mon Sep 17 00:00:00 2001
From: b-ma <benjamin.matuszewski@gmail.com>
Date: Wed, 6 Dec 2023 18:08:20 +0100
Subject: [PATCH 2/2] fix: clippy is happy!

---
 generator/templates/audio_context.tmpl.rs |  6 ++--
 generator/templates/audio_nodes.tmpl.rs   | 28 ++++++++++++++++--
 src/analyser_node.rs                      | 18 ++++++------
 src/audio_buffer.rs                       |  4 +--
 src/audio_buffer_source_node.rs           | 12 ++++----
 src/audio_context.rs                      |  4 +--
 src/delay_node.rs                         |  4 +--
 src/media_devices/get_user_media.rs       |  2 +-
 src/panner_node.rs                        | 36 +++++++++++------------
 9 files changed, 68 insertions(+), 46 deletions(-)

diff --git a/generator/templates/audio_context.tmpl.rs b/generator/templates/audio_context.tmpl.rs
index f31f940f..9d8b50bd 100644
--- a/generator/templates/audio_context.tmpl.rs
+++ b/generator/templates/audio_context.tmpl.rs
@@ -409,10 +409,8 @@ fn set_sink_id(ctx: CallContext) -> Result<JsUndefined> {
 
     let res = obj.set_sink_id_sync(sink_id);
 
-    if res.is_err() {
-        return Err(napi::Error::from_reason(
-            res.unwrap_err().to_string(),
-        ));
+    if let Err(msg) = res {
+        return Err(napi::Error::from_reason(msg.to_string()));
     }
 
     ctx.env.get_undefined()
diff --git a/generator/templates/audio_nodes.tmpl.rs b/generator/templates/audio_nodes.tmpl.rs
index 2fb2f431..75b4b6bd 100644
--- a/generator/templates/audio_nodes.tmpl.rs
+++ b/generator/templates/audio_nodes.tmpl.rs
@@ -155,7 +155,7 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                         return `
             let some_${simple_slug}_js = options_js.get::<&str, JsNumber>("${m.name}")?;
             let ${slug} = if let Some(${simple_slug}_js) = some_${simple_slug}_js {
-                ${simple_slug}_js.get_double()? as f64
+                ${simple_slug}_js.get_double()?
             } else {
                 ${m.required ? `return Err(napi::Error::from_reason(
                     "Parameter ${d.name(m)} is required".to_string(),
@@ -525,7 +525,31 @@ fn get_${d.slug(attr)}(ctx: CallContext) -> Result<JsBoolean> {
             `;
             break;
         case 'float':
+            return `
+#[js_function(0)]
+fn get_${d.slug(attr)}(ctx: CallContext) -> Result<JsNumber> {
+    let js_this = ctx.this_unchecked::<JsObject>();
+    let napi_node = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
+    let node = napi_node.unwrap();
+
+    let value = node.${d.slug(attr, true)}();
+    ctx.env.create_double(value as f64)
+}
+            `;
+            break;
         case 'double':
+            return `
+#[js_function(0)]
+fn get_${d.slug(attr)}(ctx: CallContext) -> Result<JsNumber> {
+    let js_this = ctx.this_unchecked::<JsObject>();
+    let napi_node = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
+    let node = napi_node.unwrap();
+
+    let value = node.${d.slug(attr, true)}();
+    ctx.env.create_double(value)
+}
+            `;
+            break;
         case 'unsigned long':
             return `
 #[js_function(0)]
@@ -662,7 +686,7 @@ fn set_${d.slug(attr)}(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<${d.napiName(d.node)}>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_${d.slug(attr)}(value);
 
     ctx.env.get_undefined()
diff --git a/src/analyser_node.rs b/src/analyser_node.rs
index e8b6db4e..53fb77de 100644
--- a/src/analyser_node.rs
+++ b/src/analyser_node.rs
@@ -126,14 +126,14 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
 
             let some_max_decibels_js = options_js.get::<&str, JsNumber>("maxDecibels")?;
             let max_decibels = if let Some(max_decibels_js) = some_max_decibels_js {
-                max_decibels_js.get_double()? as f64
+                max_decibels_js.get_double()?
             } else {
                 -30.
             };
 
             let some_min_decibels_js = options_js.get::<&str, JsNumber>("minDecibels")?;
             let min_decibels = if let Some(min_decibels_js) = some_min_decibels_js {
-                min_decibels_js.get_double()? as f64
+                min_decibels_js.get_double()?
             } else {
                 -100.
             };
@@ -142,7 +142,7 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
                 options_js.get::<&str, JsNumber>("smoothingTimeConstant")?;
             let smoothing_time_constant =
                 if let Some(smoothing_time_constant_js) = some_smoothing_time_constant_js {
-                    smoothing_time_constant_js.get_double()? as f64
+                    smoothing_time_constant_js.get_double()?
                 } else {
                     0.8
                 };
@@ -368,7 +368,7 @@ fn get_min_decibels(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.min_decibels();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -378,7 +378,7 @@ fn get_max_decibels(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.max_decibels();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -388,7 +388,7 @@ fn get_smoothing_time_constant(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.smoothing_time_constant();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 // -------------------------------------------------
@@ -413,7 +413,7 @@ fn set_min_decibels(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiAnalyserNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_min_decibels(value);
 
     ctx.env.get_undefined()
@@ -425,7 +425,7 @@ fn set_max_decibels(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiAnalyserNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_max_decibels(value);
 
     ctx.env.get_undefined()
@@ -437,7 +437,7 @@ fn set_smoothing_time_constant(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiAnalyserNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_smoothing_time_constant(value);
 
     ctx.env.get_undefined()
diff --git a/src/audio_buffer.rs b/src/audio_buffer.rs
index 32018919..9e957f45 100644
--- a/src/audio_buffer.rs
+++ b/src/audio_buffer.rs
@@ -8,7 +8,7 @@ use web_audio_api::{AudioBuffer, AudioBufferOptions};
 
 // helper convert [f32] to [u8]
 // https://users.rust-lang.org/t/vec-f32-to-u8/21522/7
-fn to_byte_slice<'a>(floats: &'a [f32]) -> &'a [u8] {
+fn to_byte_slice(floats: &[f32]) -> &[u8] {
     unsafe { std::slice::from_raw_parts(floats.as_ptr() as *const _, floats.len() * 4) }
 }
 
@@ -158,7 +158,7 @@ fn duration(ctx: CallContext) -> Result<JsNumber> {
     let obj = napi_obj.unwrap();
 
     let duration = obj.duration();
-    ctx.env.create_double(duration as f64)
+    ctx.env.create_double(duration)
 }
 
 #[js_function]
diff --git a/src/audio_buffer_source_node.rs b/src/audio_buffer_source_node.rs
index 854945d9..086004a6 100644
--- a/src/audio_buffer_source_node.rs
+++ b/src/audio_buffer_source_node.rs
@@ -134,14 +134,14 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
 
             let some_loop_end_js = options_js.get::<&str, JsNumber>("loopEnd")?;
             let loop_end = if let Some(loop_end_js) = some_loop_end_js {
-                loop_end_js.get_double()? as f64
+                loop_end_js.get_double()?
             } else {
                 0.
             };
 
             let some_loop_start_js = options_js.get::<&str, JsNumber>("loopStart")?;
             let loop_start = if let Some(loop_start_js) = some_loop_start_js {
-                loop_start_js.get_double()? as f64
+                loop_start_js.get_double()?
             } else {
                 0.
             };
@@ -393,7 +393,7 @@ fn get_loop_start(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.loop_start();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -403,7 +403,7 @@ fn get_loop_end(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.loop_end();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 // -------------------------------------------------
@@ -444,7 +444,7 @@ fn set_loop_start(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiAudioBufferSourceNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_loop_start(value);
 
     ctx.env.get_undefined()
@@ -456,7 +456,7 @@ fn set_loop_end(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiAudioBufferSourceNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_loop_end(value);
 
     ctx.env.get_undefined()
diff --git a/src/audio_context.rs b/src/audio_context.rs
index 25c95923..f2508622 100644
--- a/src/audio_context.rs
+++ b/src/audio_context.rs
@@ -580,8 +580,8 @@ fn set_sink_id(ctx: CallContext) -> Result<JsUndefined> {
 
     let res = obj.set_sink_id_sync(sink_id);
 
-    if res.is_err() {
-        return Err(napi::Error::from_reason(res.unwrap_err().to_string()));
+    if let Err(msg) = res {
+        return Err(napi::Error::from_reason(msg.to_string()));
     }
 
     ctx.env.get_undefined()
diff --git a/src/delay_node.rs b/src/delay_node.rs
index 72ca9331..40f628ef 100644
--- a/src/delay_node.rs
+++ b/src/delay_node.rs
@@ -89,14 +89,14 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
         Either::A(options_js) => {
             let some_max_delay_time_js = options_js.get::<&str, JsNumber>("maxDelayTime")?;
             let max_delay_time = if let Some(max_delay_time_js) = some_max_delay_time_js {
-                max_delay_time_js.get_double()? as f64
+                max_delay_time_js.get_double()?
             } else {
                 1.
             };
 
             let some_delay_time_js = options_js.get::<&str, JsNumber>("delayTime")?;
             let delay_time = if let Some(delay_time_js) = some_delay_time_js {
-                delay_time_js.get_double()? as f64
+                delay_time_js.get_double()?
             } else {
                 0.
             };
diff --git a/src/media_devices/get_user_media.rs b/src/media_devices/get_user_media.rs
index b12e39ae..de8e70c9 100644
--- a/src/media_devices/get_user_media.rs
+++ b/src/media_devices/get_user_media.rs
@@ -43,7 +43,7 @@ pub(crate) fn napi_get_user_media(ctx: CallContext) -> Result<JsObject> {
                 }
 
                 if let Ok(Some(js_latency)) = js_constraints.get::<&str, JsNumber>("latency") {
-                    let latency = js_latency.get_double()? as f64;
+                    let latency = js_latency.get_double()?;
                     constraints.latency = Some(latency);
                 }
 
diff --git a/src/panner_node.rs b/src/panner_node.rs
index 19d57834..ac1c3697 100644
--- a/src/panner_node.rs
+++ b/src/panner_node.rs
@@ -195,42 +195,42 @@ fn constructor(ctx: CallContext) -> Result<JsUndefined> {
 
             let some_ref_distance_js = options_js.get::<&str, JsNumber>("refDistance")?;
             let ref_distance = if let Some(ref_distance_js) = some_ref_distance_js {
-                ref_distance_js.get_double()? as f64
+                ref_distance_js.get_double()?
             } else {
                 1.
             };
 
             let some_max_distance_js = options_js.get::<&str, JsNumber>("maxDistance")?;
             let max_distance = if let Some(max_distance_js) = some_max_distance_js {
-                max_distance_js.get_double()? as f64
+                max_distance_js.get_double()?
             } else {
                 10000.
             };
 
             let some_rolloff_factor_js = options_js.get::<&str, JsNumber>("rolloffFactor")?;
             let rolloff_factor = if let Some(rolloff_factor_js) = some_rolloff_factor_js {
-                rolloff_factor_js.get_double()? as f64
+                rolloff_factor_js.get_double()?
             } else {
                 1.
             };
 
             let some_cone_inner_angle_js = options_js.get::<&str, JsNumber>("coneInnerAngle")?;
             let cone_inner_angle = if let Some(cone_inner_angle_js) = some_cone_inner_angle_js {
-                cone_inner_angle_js.get_double()? as f64
+                cone_inner_angle_js.get_double()?
             } else {
                 360.
             };
 
             let some_cone_outer_angle_js = options_js.get::<&str, JsNumber>("coneOuterAngle")?;
             let cone_outer_angle = if let Some(cone_outer_angle_js) = some_cone_outer_angle_js {
-                cone_outer_angle_js.get_double()? as f64
+                cone_outer_angle_js.get_double()?
             } else {
                 360.
             };
 
             let some_cone_outer_gain_js = options_js.get::<&str, JsNumber>("coneOuterGain")?;
             let cone_outer_gain = if let Some(cone_outer_gain_js) = some_cone_outer_gain_js {
-                cone_outer_gain_js.get_double()? as f64
+                cone_outer_gain_js.get_double()?
             } else {
                 0.
             };
@@ -519,7 +519,7 @@ fn get_ref_distance(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.ref_distance();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -529,7 +529,7 @@ fn get_max_distance(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.max_distance();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -539,7 +539,7 @@ fn get_rolloff_factor(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.rolloff_factor();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -549,7 +549,7 @@ fn get_cone_inner_angle(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.cone_inner_angle();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -559,7 +559,7 @@ fn get_cone_outer_angle(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.cone_outer_angle();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 #[js_function(0)]
@@ -569,7 +569,7 @@ fn get_cone_outer_gain(ctx: CallContext) -> Result<JsNumber> {
     let node = napi_node.unwrap();
 
     let value = node.cone_outer_gain();
-    ctx.env.create_double(value as f64)
+    ctx.env.create_double(value)
 }
 
 // -------------------------------------------------
@@ -621,7 +621,7 @@ fn set_ref_distance(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_ref_distance(value);
 
     ctx.env.get_undefined()
@@ -633,7 +633,7 @@ fn set_max_distance(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_max_distance(value);
 
     ctx.env.get_undefined()
@@ -645,7 +645,7 @@ fn set_rolloff_factor(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_rolloff_factor(value);
 
     ctx.env.get_undefined()
@@ -657,7 +657,7 @@ fn set_cone_inner_angle(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_cone_inner_angle(value);
 
     ctx.env.get_undefined()
@@ -669,7 +669,7 @@ fn set_cone_outer_angle(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_cone_outer_angle(value);
 
     ctx.env.get_undefined()
@@ -681,7 +681,7 @@ fn set_cone_outer_gain(ctx: CallContext) -> Result<JsUndefined> {
     let napi_node = ctx.env.unwrap::<NapiPannerNode>(&js_this)?;
     let node = napi_node.unwrap();
 
-    let value = ctx.get::<JsNumber>(0)?.get_double()? as f64;
+    let value = ctx.get::<JsNumber>(0)?.get_double()?;
     node.set_cone_outer_gain(value);
 
     ctx.env.get_undefined()