refactor: parse query strings in http-api endpoint

Author: niinpatel

src/core/runtime/dns-nodejs.js

@@ -9,7 +9,7 @@ const MAX_RECURSIVE_DEPTH = 32
 
 module.exports = (domain, opts, callback) => {
   // recursive is true by default, it's set to false only if explicitly passed as argument in opts
-  const recursive = opts.recursive == null || opts.recursive.toString() !== 'false'
+  const recursive = opts.recursive == null ? true : Boolean(opts.recursive)
 
   let depth
   if (recursive) {

src/http/api/resources/dns.js

@@ -3,12 +3,15 @@
 const Boom = require('boom')
 
 module.exports = async (request, h) => {
-  const { arg: domain, recursive, format } = request.query
+  let { arg: domain, recursive, format } = request.query
 
   if (!domain) {
     throw Boom.badRequest("Argument 'domain' is required")
   }
 
+  // query parameters are passed as strings and need to be parsed to expected type
+  recursive = !(recursive && recursive === 'false')
+
   const path = await request.server.app.ipfs.dns(domain, { recursive, format })
   return h.response({
     Path: path