HTTP API server: parsing query string as binary in pubsub publish

Author: pgte

package.json

@@ -93,6 +93,7 @@
   },
   "dependencies": {
     "async": "^2.6.0",
+    "binary-querystring": "^0.1.1",
     "bl": "^1.2.1",
     "boom": "^7.1.1",
     "bs58": "^4.0.1",

src/http/api/resources/pubsub.js

@@ -2,6 +2,7 @@
 
 const PassThrough = require('stream').PassThrough
 const bs58 = require('bs58')
+const binaryQueryString = require('binary-querystring')
 
 exports = module.exports
 
@@ -58,7 +59,9 @@ exports.publish = {
   handler: (request, reply) => {
     const arg = request.query.arg
     const topic = arg[0]
-    const buf = arg[1]
+
+    const rawArgs = binaryQueryString(request.url.search)
+    const buf = rawArgs.arg[1]
 
     const ipfs = request.server.app.ipfs
 
@@ -70,7 +73,7 @@ exports.publish = {
       return reply(new Error('Missing buf'))
     }
 
-    ipfs.pubsub.publish(topic, Buffer.from(String(buf)), (err) => {
+    ipfs.pubsub.publish(topic, buf, (err) => {
       if (err) {
         return reply(new Error(`Failed to publish to topic ${topic}: ${err}`))
       }

test/interop/pubsub.js

@@ -83,7 +83,7 @@ describe('pubsub', function () {
       ], done)
     })
   })
-  
+
   describe('ascii data', () => {
     const data = Buffer.from('hello world')
 
@@ -258,7 +258,7 @@ describe('pubsub', function () {
 
   describe('binary data', () => {
     const data = Buffer.from('a36161636179656162830103056164a16466666666f400010203040506070809', 'hex')
-    
+
     it('publish from Go, subscribe on Go', (done) => {
       const topic = 'pubsub-binary-go-go'
       let n = 0