feat: pinpoint

Author: daviddias

src/core/components/ping-pull-stream.js

@@ -22,8 +22,7 @@ module.exports = function pingPullStream (self) {
     getPeer(self._libp2pNode, source, peerId, (err, peer) => {
       if (err) {
         log.error(err)
-        source.push(err)
-        source.end()
+        source.end(err)
         return
       }
 

src/http/api/resources/ping.js

@@ -43,6 +43,9 @@ exports.get = {
     const responseStream = toStream.source(source)
     const stream2 = new PassThrough()
     pump(responseStream, stream2)
+    // TODO: here lies the issue
+    // The fact that ping can fail after it starts writting some success ndjson
+    // responses is not very friendly to how Hapi expects this stream to work
     reply(stream2).type('application/json').header('X-Chunked-Output', '1')
   }
 }