feat: add --pass to command line #1135

Allow the pass phrase to specified on the jsipfs command line.

Author: richardschneider

src/cli/bin.js

@@ -21,6 +21,11 @@ const cli = yargs
     default: false,
     coerce: ('silent', silent => silent ? utils.disablePrinting() : silent)
   })
+  .option('pass', {
+    desc: 'Pass phrase for the keys',
+    type: 'string',
+    default: ''
+  })
   .commandDir('commands')
   .demandCommand(1)
   .fail((msg, err, yargs) => {
@@ -59,7 +64,7 @@ if (args[0] === 'daemon' || args[0] === 'init') {
     if (err) {
       throw err
     }
-    utils.getIPFS(argv.api, (err, ipfs, cleanup) => {
+    utils.getIPFS(argv, (err, ipfs, cleanup) => {
       if (err) { throw err }
 
       cli

src/cli/utils.js

@@ -38,15 +38,16 @@ function getAPICtl (apiAddr) {
   return APIctl(apiAddr)
 }
 
-exports.getIPFS = (apiAddr, callback) => {
-  if (apiAddr || isDaemonOn()) {
-    return callback(null, getAPICtl(apiAddr), (cb) => cb())
+exports.getIPFS = (argv, callback) => {
+  if (argv.api || isDaemonOn()) {
+    return callback(null, getAPICtl(argv.api), (cb) => cb())
   }
 
   const node = new IPFS({
     repo: exports.getRepoPath(),
     init: false,
     start: false,
+    pass: argv.pass,
     EXPERIMENTAL: {
       pubsub: true
     }

src/core/components/pre-start.js

@@ -13,7 +13,7 @@ module.exports = function preStart (self) {
   return (callback) => {
     self.log('pre-start')
 
-    self._keychain = new Keychain(self._repo.keys, { passPhrase: 'todo do not hardcode the pass phrase' })
+    self._keychain = new Keychain(self._repo.keys, { passPhrase: self._options.pass || 'todo do not hardcode the pass phrase' })
 
     waterfall([
       (cb) => self._repo.config.get(cb),

src/http/index.js

@@ -67,6 +67,7 @@ function HttpApi (repo, config, cliArgs) {
             init: init,
             start: true,
             config: config,
+            pass: cliArgs && cliArgs.pass,
             EXPERIMENTAL: {
               pubsub: cliArgs && cliArgs.enablePubsubExperiment,
               sharding: cliArgs && cliArgs.enableShardingExperiment