refactor: move tests to interface-ipfs-core

Author: niinpatel

src/cli/commands/dns.js

@@ -21,7 +21,7 @@ module.exports = {
   handler ({ getIpfs, domain, resolve, recursive, format }) {
     resolve((async () => {
       const ipfs = await getIpfs()
-      const path = await ipfs.dns(domain, opts)
+      const path = await ipfs.dns(domain, { recursive, format })
       print(path)
     })())
   }

src/core/runtime/dns-nodejs.js

@@ -9,11 +9,11 @@ const MAX_RECURSIVE_DEPTH = 32
 
 module.exports = (domain, opts, callback) => {
   // recursive is true by default, it's set to false only if explicitly passed as argument in opts
-  const recursive = opts.recursive == null ? true : Boolean(opts.recursive)
+  const recursive = opts.recursive.toString() !== 'false'
 
   let depth
   if (recursive) {
-    depth = maxRecursiveDepth
+    depth = MAX_RECURSIVE_DEPTH
   }
 
   return recursiveResolveDnslink(domain, depth, callback)

src/http/api/resources/dns.js

@@ -3,13 +3,13 @@
 const Boom = require('boom')
 
 module.exports = async (request, h) => {
-  const { arg: domain, ...opts } = request.query
+  const { arg: domain, recursive, format } = request.query
 
   if (!domain) {
     throw Boom.badRequest("Argument 'domain' is required")
   }
 
-  const path = await request.server.app.ipfs.dns(domain, opts)
+  const path = await request.server.app.ipfs.dns(domain, { recursive, format })
   return h.response({
     Path: path
   })