Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Commit 5dd7ed1

Browse files
author
Alan Shaw
committed
chore: add temporary skips for tests designed for DHT PR
These need to be unskipped when #856 gets merged. This frees us to merge other changes while we're waiting for fixes to happen there. License: MIT Signed-off-by: Alan Shaw <[email protected]>
1 parent 4e1249b commit 5dd7ed1

File tree

4 files changed

+5
-32
lines changed

4 files changed

+5
-32
lines changed

test/cli/name.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ describe('name', () => {
181181
})
182182
})
183183

184-
describe('using dht', () => {
184+
describe.skip('using dht', () => {
185185
const passPhrase = hat()
186186
const pass = '--pass ' + passPhrase
187187
const name = 'test-key-' + hat()

test/core/interface.spec.js

Lines changed: 1 addition & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -47,35 +47,7 @@ describe('interface-ipfs-core tests', () => {
4747
})
4848

4949
tests.dht(dhtCommonFactory, {
50-
skip: isNode ? [
51-
// dht.provide
52-
{
53-
name: 'should provide local CID',
54-
reason: 'FIXME: Circuit not enabled and all transports failed to dial peer'
55-
},
56-
{
57-
name: 'should allow multiple CIDs to be passed',
58-
reason: 'FIXME: Circuit not enabled and all transports failed to dial peer'
59-
},
60-
{
61-
name: 'should provide a CIDv1',
62-
reason: 'FIXME: Circuit not enabled and all transports failed to dial peer'
63-
},
64-
// dht.get
65-
{
66-
name: 'should get a value after it was put on another node',
67-
reason: 'FIXME: callback is not a function'
68-
},
69-
// dht.findprovs
70-
{
71-
name: 'should provide from one node and find it through another node',
72-
reason: 'FIXME: Timeout of 80000ms exceeded'
73-
},
74-
{
75-
name: 'should return the other node in the query',
76-
reason: 'FIXME: always auto-skiped from within test'
77-
}
78-
] : true
50+
skip: { reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/856 is merged' }
7951
})
8052

8153
tests.filesRegular(defaultCommonFactory, {

test/core/name.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,8 @@ describe('name', function () {
193193
})
194194
})
195195

196-
describe('work with dht', () => {
196+
// TODO: unskip when https://github.com/ipfs/js-ipfs/pull/856 is merged
197+
describe.skip('work with dht', () => {
197198
let nodes
198199
let nodeA
199200
let nodeB

test/http-api/interface.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
2222
})
2323

2424
tests.dht(defaultCommonFactory, {
25-
skip: { reason: 'TODO: DHT is not implemented in js-ipfs yet!' }
25+
skip: { reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/856 is merged' }
2626
})
2727

2828
tests.filesRegular(defaultCommonFactory)

0 commit comments

Comments
 (0)