feat: dns returns partial result on recursion limit exceeded

niinpatel · niinpatel · commit 4e3316f0128f · 2019-03-16T14:38:12.000+05:30
diff --git a/src/core/runtime/dns-nodejs.js b/src/core/runtime/dns-nodejs.js
@@ -21,7 +21,8 @@ module.exports = (domain, opts, callback) => {
 
 function recursiveResolveDnslink (domain, depth, callback) {
   if (depth === 0) {
-    return callback(errcode(`recursion limit exceeded`, 'ERR_DNSLINK_RECURSION_LIMIT'))
+    // return partial result if recursion limit exceeded along with error
+    return callback(errcode(`recursion limit exceeded`, 'ERR_DNSLINK_RECURSION_LIMIT'), domain)
   }
 
   return resolveDnslink(domain)

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,8 @@ module.exports = (domain, opts, callback) => {`
`21`	`21`
`22`	`22`	`function recursiveResolveDnslink (domain, depth, callback) {`
`23`	`23`	`if (depth === 0) {`
`24`		- return callback(errcode(`recursion limit exceeded`, 'ERR_DNSLINK_RECURSION_LIMIT'))
	`24`	`+ // return partial result if recursion limit exceeded along with error`
	`25`	+ return callback(errcode(`recursion limit exceeded`, 'ERR_DNSLINK_RECURSION_LIMIT'), domain)
`25`	`26`	`}`
`26`	`27`
`27`	`28`	`return resolveDnslink(domain)`