-
Notifications
You must be signed in to change notification settings - Fork 509
Pinning integration: Stub UI for Files screen #1500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@lidel and @rafaelramalho19 -- Updated Figma high-res screens can be found here. This includes redrawn screens from the original Pinning Summit concept mockups (adjusted for changes discussed in recent meetings), plus errors/exception/modal screens found along the way, to wit:
NOTE: I'm not happy with the "pin status" icon, but wanted to throw it out there to illustrate the ramifications of different approaches to how we convey "all/some/none" in terms of pin status.
Note that some of the new screens generated in creating this content also required additions to be made to the screens in #1501, so please have a quick look there as you're able. Would appreciate feedback/discussion with you both before we take this wider. Thanks! |
ETA: Considerable revisions to the document based on in-Figma comments. Icons are in a better situation; we still need to determine whether we'll be allowing manual pinning in this release. Awaiting consensus from @rafaelramalho19 @lidel @momack2 but getting closer. |
I don't think "manual pin" is a problem, we could implement it if the time allows, but can also remove it from V1 to reduce the scope of UIs to implement. However, what is unclear to me is the cost of getting "pin status at remote service" for every file listed on Files screen. (would webui make the call to remote service, or would it be done by go-ipfs? would it be possible to request status for multiple CIDs in bulk? how do we handle lazy-loading of those states etc). Worst case scenario: we could plan for eventuality in which the V1 only shows a local pin as it does today and remote pin status is fetched only when user explicitly check "pinning service modal" via the dot menu. |
@rafaelramalho19 -- per planning discussion this morning, can you please prioritize work on this once 2.11 is released? We have agreed Figma files here: https://www.figma.com/file/4cYoTNbjnnV7I7qeOEhjg8/WebUI-Desktop-Pinning-Hi-Fi-Screens-Files?node-id=0%3A1 Please let me know if I can clarify anything. Thank you! |
Notes from our discussion today:
|
@lidel @rafaelramalho19 I've isolated the bottom-drawer implementation part in #1682 for future work. |
Uh oh!
There was an error while loading. Please reload this page.
Note: This issue is part of a larger pinning service integration epic undertaken spring/summer 2020.
In brief
Stub out UI for Files screen of Web UI/Desktop, as follows:
High-res screens as Figma doc are here.
The text was updated successfully, but these errors were encountered: