Skip to content

Regression: ipfs add no longer works for folders #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Netherdrake opened this issue Oct 8, 2016 · 2 comments
Closed

Regression: ipfs add no longer works for folders #75

Netherdrake opened this issue Oct 8, 2016 · 2 comments

Comments

@Netherdrake
Copy link

Netherdrake commented Oct 8, 2016

In [28]: !ipfs add  -r tmp/
added QmQDze3FMH2GxVfomdghYeLGAkQ4QJrvcMGKykW7zBwJUH tmp/Devcon2_-_Orbit_-_Distributed__real-time_Web3_application_with_IPFS_and_Ethereum.pdf
added QmSTbjW14eBr8ZgJzxjDtEFF9CBhVccvjkbcGeiMthm6xC tmp/Maker_Devcon2.pdf
added QmXKtze4Z97osJGjvRZPLb8cfhf2sh2nShy9zqsxTTnrFf tmp/Zcash-slides.pdf
added QmTkEnbpLjuotXxqK8Wyn4tozMJXaAwqBtQguKQ7yyo4kf tmp/test/site4.png
added QmeMBXfX3xqQnoxPa4We5rLoMxqcbUmqDSnsDKAXFtW8yY tmp/test
added QmQsYbAp34mGm4RHxZxjpRruWzoWEAcVyq5m43tegA6psq tmp

In [29]: c.add('tmp/', recursive=True)
Out[29]: 
[{'Hash': 'QmT5DQ74JNwwhH7y5LmAjEND9Yu1iukaxBhdjQnwxMCHj8', 'Name': 'tmp/'},
 {'Hash': 'QmPtdDjMCtf3BgMytQqwfMfvru6bmxNDAHyvMjaivYKCuY', 'Name': 'tmp'}]

In [30]: c.add('tmp', recursive=True)
Out[30]: {'Hash': 'QmRkjAFXWVfY9DQvfeQJ2UfGdvEygJQVoS3YkfobEDDVo8', 'Name': 'tmp'}

In [31]: 

Furthermore, QmRkjAFXWVfY9DQvfeQJ2UfGdvEygJQVoS3YkfobEDDVo8, QmPtdDjMCtf3BgMytQqwfMfvru6bmxNDAHyvMjaivYKCuY and QmT5DQ74JNwwhH7y5LmAjEND9Yu1iukaxBhdjQnwxMCHj8 appears to be garbage.

@Netherdrake Netherdrake changed the title Regression: ipfs add no longer works in recursive mode Regression: ipfs add no longer works for folders Oct 8, 2016
@ntninja
Copy link
Contributor

ntninja commented Oct 8, 2016

Thanks for reporting this! Are you using the legacy ipfsApi (for IPFS 0.3.x) or the updated ipfsapi (for IFPS 0.4+) module?
This looks very similar to #41.

@Netherdrake
Copy link
Author

Netherdrake commented Oct 8, 2016

I am traveling, so I'm working on another computer. The code that used to work stopped working, so that was pretty confusing. I was indeed using ipfsApi on ipfs v.0.4.2, which doesn't seem to work.

Thanks for the tip, I didn't know about ipfsapi :)

Everything works well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants