error on non buffer arguments to pubsub.publish

dignifiedquire · dignifiedquire · commit eb68ec3e8988 · 2016-12-21T14:51:02.000+01:00
diff --git a/src/api/pubsub.js b/src/api/pubsub.js
@@ -57,11 +57,13 @@ module.exports = (send) => {
       }
     },
     publish: promisify((topic, data, callback) => {
-      const buf = Buffer.isBuffer(data) ? data : new Buffer(data)
+      if (!Buffer.isBuffer(data)) {
+        return callback(new Error('data must be a Buffer'))
+      }
 
       const request = {
         path: 'pubsub/pub',
-        args: [topic, buf]
+        args: [topic, data]
       }
 
       send(request, callback)

Original file line number	Diff line number	Diff line change
`@@ -57,11 +57,13 @@ module.exports = (send) => {`
`57`	`57`	`}`
`58`	`58`	`},`
`59`	`59`	`publish: promisify((topic, data, callback) => {`
`60`		`- const buf = Buffer.isBuffer(data) ? data : new Buffer(data)`
	`60`	`+ if (!Buffer.isBuffer(data)) {`
	`61`	`+ return callback(new Error('data must be a Buffer'))`
	`62`	`+ }`
`61`	`63`
`62`	`64`	`const request = {`
`63`	`65`	`path: 'pubsub/pub',`
`64`		`- args: [topic, buf]`
	`66`	`+ args: [topic, data]`
`65`	`67`	`}`
`66`	`68`
`67`	`69`	`send(request, callback)`