feat: chevron-expand and chevron-collapse icons #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Adds two new icons to ionicons:
chevron-expand
andchevron-collapse
.The SVG optimization implementation that we built around
svgo
had issues if you pre-optimized the SVG. I updated the implementation so that we can provide SVGs that already have the fill or stroke set tocurrentColor
, which was required to get the new icons to be compatible with thecolor
property ofion-icon
.Testing
npm ci
)npm run build
)npm run start
)You can update the
src/index.html
template to test that colors work correctly with the new icons (and display variants):You can also view the cheatsheet at the bottom of the index template to see the raw rendering of the SVG.
Other information
Dev-build:
7.0.1-dev.11679510424.1ffdf3ba