Skip to content

[v4 beta-12]: perf: Build process is drastically slower #15965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukeisontheroad opened this issue Oct 16, 2018 · 2 comments
Closed

[v4 beta-12]: perf: Build process is drastically slower #15965

lukeisontheroad opened this issue Oct 16, 2018 · 2 comments
Labels

Comments

@lukeisontheroad
Copy link

lukeisontheroad commented Oct 16, 2018

Bug Report

Ionic Info (before upgrade)

Ionic:

   ionic (Ionic CLI)             : 4.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.11
   @angular-devkit/build-angular : 0.8.5
   @angular-devkit/schematics    : 0.8.5
   @angular/cli                  : 6.2.5
   @ionic/angular-toolkit        : 1.0.0

System:

   NodeJS : v9.11.2 (/usr/local/lib/node_modules/node/bin/node)
   npm    : 6.1.0
   OS     : macOS

Ionic Info (after upgrade)

Ionic:

   ionic (Ionic CLI)             : 4.2.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.12
   @angular-devkit/build-angular : 0.8.5
   @angular-devkit/schematics    : 0.8.5
   @angular/cli                  : 6.2.5
   @ionic/angular-toolkit        : 1.0.0

System:

   NodeJS : v9.11.2 (/usr/local/lib/node_modules/node/bin/node)
   npm    : 6.1.0
   OS     : macOS

Describe the Bug
After upgrading from beta 11 to beta 12, I noticed a big difference in compile time.

Before (4.0.0-beta.11):
[ng] ℹ 「wdm」: Compiling...
[ng]
[ng] Date: 2018-10-16T11:58:26.944Z - Hash: 100fa7e4d25e03303631 - Time: 8463ms
[ng] 173 unchanged chunks
[ng] chunk {tabs-tabs-module} tabs-tabs-module.js, tabs-tabs-module.js.map (tabs-tabs-module) 25.9 kB [rendered]
[ng] ℹ 「wdm」: Compiled successfully.

After (4.0.0-beta.12):
[ng] ℹ 「wdm」: Compiling...
[ng]
[ng] Date: 2018-10-16T12:04:02.336Z - Hash: 9a0c1949d63b849a7238 - Time: 74036ms
[ng] 173 unchanged chunks
[ng] chunk {tabs-tabs-module} tabs-tabs-module.js, tabs-tabs-module.js.map (tabs-tabs-module) 25.9 kB [rendered]
[ng] ℹ 「wdm」: Compiled successfully.

It's only an incremental change (color from light to dark in one of the components), but it almost takes as long as the initial compile duration.

Steps to Reproduce
Steps to reproduce the behavior:

  1. ionic start myApp tabs --type=angular
  2. ionic serve
  3. wait for the first build
  4. make a small change (i.e. tabs.page.html to )
  5. check the complication time
  6. downgrade "@ionic/angular": "4.0.0-beta.12" to "@ionic/angular": "4.0.0-beta.11"
  7. repeat steps 2-5

Related Code
Starter project & my custom project

Expected Behavior
Similar build performance as before (at least not x10 times slower)

Additional Context
None

@ionitron-bot ionitron-bot bot added the triage label Oct 16, 2018
@jase88
Copy link

jase88 commented Oct 16, 2018

Update to Node 10 is right. Compiling time from 79s to 7s.

Duplicate of #15800 or #15644

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 15, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants