From f6b8937306422208b598c4cf9defca753fb6bcc2 Mon Sep 17 00:00:00 2001 From: amandaesmith3 Date: Tue, 9 Apr 2024 12:48:47 -0500 Subject: [PATCH 1/3] docs(migration): add info about removing old light palette colors --- docs/updating/8-0.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/docs/updating/8-0.md b/docs/updating/8-0.md index afe4557370a..d7953bef568 100644 --- a/docs/updating/8-0.md +++ b/docs/updating/8-0.md @@ -74,6 +74,26 @@ npm install @ionic/core@next The following changes are not required to update to Ionic 8 as your application will continue to work. However, we recommend making the following changes to ensure you can use the new features in Ionic 8. +### Light Theme + +Previous versions shipped a set of default color variables for the light theme: + +```css +/** Ionic CSS Variables **/ +:root { + /** primary **/ + --ion-color-primary: #3880ff; + --ion-color-primary-rgb: 56, 128, 255; + --ion-color-primary-contrast: #ffffff; + --ion-color-primary-contrast-rgb: 255, 255, 255; + ... +} +``` + +If you are not using a custom color scheme, these color variables should all be removed. In Ionic Framework version 8, the default colors have been updated to improve accessibility. The new palette is also automatically included with all Ionic apps. Removing the old color variables ensures that the latest palette is not overwritten. + +You can read more about the new color palette in the [Ionic v8 announcement](https://ionic.io/blog/announcing-the-ionic-8-beta). + ### Dark Theme In previous versions, it was recommended to define the dark theme in the following way: From 0a291650ef21ecad859b99bb4f2d262bdc6efe38 Mon Sep 17 00:00:00 2001 From: Amanda Johnston <90629384+amandaejohnston@users.noreply.github.com> Date: Tue, 9 Apr 2024 13:19:13 -0500 Subject: [PATCH 2/3] Update docs/updating/8-0.md Co-authored-by: Liam DeBeasi --- docs/updating/8-0.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/updating/8-0.md b/docs/updating/8-0.md index d7953bef568..51d43ee0547 100644 --- a/docs/updating/8-0.md +++ b/docs/updating/8-0.md @@ -90,7 +90,9 @@ Previous versions shipped a set of default color variables for the light theme: } ``` -If you are not using a custom color scheme, these color variables should all be removed. In Ionic Framework version 8, the default colors have been updated to improve accessibility. The new palette is also automatically included with all Ionic apps. Removing the old color variables ensures that the latest palette is not overwritten. +In Ionic Framework version 8, the default color palette is included as long as `core.css` is imported. Removing the old color variables ensures that the latest palette is not overwritten. + +Developers who are customizing this color palette can continue to keep the custom variables values, but any of the variables that use the default values should be removed. You can read more about the new color palette in the [Ionic v8 announcement](https://ionic.io/blog/announcing-the-ionic-8-beta). From 3b2ec52bebd9c72ae45bb5ff57c45988e8bec4bd Mon Sep 17 00:00:00 2001 From: amandaesmith3 Date: Tue, 9 Apr 2024 13:30:20 -0500 Subject: [PATCH 3/3] lint --- docs/updating/8-0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/updating/8-0.md b/docs/updating/8-0.md index 51d43ee0547..fa55dc63bc4 100644 --- a/docs/updating/8-0.md +++ b/docs/updating/8-0.md @@ -86,7 +86,7 @@ Previous versions shipped a set of default color variables for the light theme: --ion-color-primary-rgb: 56, 128, 255; --ion-color-primary-contrast: #ffffff; --ion-color-primary-contrast-rgb: 255, 255, 255; - ... + /* ... */ } ```