Skip to content

fix(modal): controller playground uses v7 label syntax #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2023
Merged

fix(modal): controller playground uses v7 label syntax #2891

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb44c68
fix(modal): controller playground uses v7 label syntax
sean-perkins Apr 7, 2023
8f31abc
chore: remove unused imports
sean-perkins Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions static/usage/v7/modal/controller/angular/modal-example_component_html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
</ion-header>
<ion-content class="ion-padding">
<ion-item>
<ion-label position="stacked">Your name</ion-label>
<ion-input [(ngModel)]="name" placeholder="Your name"></ion-input>
<ion-input labelPlacement="stacked" label="Enter your name" [(ngModel)]="name" placeholder="Your name"></ion-input>
</ion-item>
</ion-content>
```
3 changes: 1 addition & 2 deletions static/usage/v7/modal/controller/demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@
</ion-header>
<ion-content class="ion-padding">
<ion-item>
<ion-label position="stacked">Enter your name</ion-label>
<ion-input type="text" placeholder="Your name"></ion-input>
<ion-input type="text" label="Enter your name" label-placement="stacked" placeholder="Your name"></ion-input>
</ion-item>
</ion-content>
`;
Expand Down
3 changes: 1 addition & 2 deletions static/usage/v7/modal/controller/javascript.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
</ion-header>
<ion-content class="ion-padding">
<ion-item>
<ion-label position="stacked">Enter your name</ion-label>
<ion-input type="text" placeholder="Your name"></ion-input>
<ion-input type="text" label-placement="stacked" label="Enter your name" placeholder="Your name"></ion-input>
</ion-item>
</ion-content>
`;
Expand Down
3 changes: 1 addition & 2 deletions static/usage/v7/modal/controller/react.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ const ModalExample = ({
</IonHeader>
<IonContent className="ion-padding">
<IonItem>
<IonLabel position="stacked">Enter your name</IonLabel>
<IonInput ref={inputRef} placeholder="Your name" />
<IonInput ref={inputRef} labelPlacement="stacked" label="Enter your name" placeholder="Your name" />
</IonItem>
</IonContent>
</IonPage>
Expand Down
3 changes: 1 addition & 2 deletions static/usage/v7/modal/controller/vue/modal_vue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
</ion-header>
<ion-content class="ion-padding">
<ion-item>
<ion-label position="stacked">Your name</ion-label>
<ion-input v-model="name" placeholder="Your name"></ion-input>
<ion-input label-placement="stacked" label="Enter your name" v-model="name" placeholder="Your name"></ion-input>
</ion-item>
</ion-content>
</template>
Expand Down