-
Notifications
You must be signed in to change notification settings - Fork 670
Investigate HMR #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
hello, I think this feature is important with development process. Can you make some simple instruction to run custom script in |
@hiepxanh Sorry, somehow I missed your comment. This issue is here because I'd like to provide a way to develop with HMR out of the box for Ionic. Ideally it'd be enabled by default, assuming it works well with Angular and Ionic (this is what needs to be investigated). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
If you encounter issues with that guide, post it in the angular-cli repo, not here. Ionic does not officially support HMR for Angular yet. |
Hi @dwieeb I think this may require revision as HMR has been presented on the forum as well as in the cli? https://forum.ionicframework.com/t/ionic-5-angular-11-and-hot-module-replacement/199956 Nevertheless I wonder if it is implemented correctly as the --hmr flag is not passed on https://forum.ionicframework.com/t/ionic-5-angular-11-and-hot-module-replacement/199956/4 |
@dwieeb I think HMR is supported in Angular, and due to what @Tommertom says, it should be working fine, I think this 2 years old ticket can be resolved now. |
@almothafar Have you tried it with ionic 6? If yes then please let me know the CLI for that? I use this with a native device
|
@Sampath-Lokuge as far as I remember, there is nothing changed from 5 to 6, I can't check now as I left that job now and no more working with Ionic |
We should investigate HMR and possibly enable it by default at some point.
https://github.com/angular/angular-cli/wiki/stories-configure-hmr
The text was updated successfully, but these errors were encountered: