Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

[1.2.2] Some assets not compiled until ionic serve stopped then run again #859

Closed
brettdorrans opened this issue Mar 29, 2017 · 5 comments
Closed

Comments

@brettdorrans
Copy link

brettdorrans commented Mar 29, 2017

Note: for support questions, please use one of these channels:

https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/

Short description of the problem:

Using 1.2.2 of ionic-app-scripts and ionic serve - occasionally components will not be compiled. e.g., if I make a change to a Provider, the build completes and reloads the browser, but the changes are not reflected (or intermittently reflected, sometimes I can refresh the page and they'll appear, but after another refresh will be gone again).

What behavior are you expecting?

All changes to be reflected and persistent after build completes.

Steps to reproduce:

  1. Using 'ionic serve' on ionic-app-scripts 1.2.2, save file and wait for build process to complete.
  2. Occasionally/intermittently your changes will not be reflected.
  3. Refresh page manually and changes will sometimes appear, but subsequent refreshes may make them disappear again. I can't reliably reproduce this.

Which @ionic/app-scripts version are you using?

Ionic Framework Version: 2.2.0
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.2.2
ios-deploy version: 1.9.0
ios-sim version: 5.0.13
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2.1 Build version 8C1002

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Is probably related to #825

@brettdorrans brettdorrans changed the title [1.2.1] Some assets not compiled until ionic serve stopped then run again [1.2.2] Some assets not compiled until ionic serve stopped then run again Mar 29, 2017
@brettdorrans
Copy link
Author

Had initially reported this on 1.2.1, upgraded to 1.2.2 and issue persists.

@brettdorrans
Copy link
Author

Issue also present on nightly 1.2.2-201703281515

@brettdorrans
Copy link
Author

brettdorrans commented Mar 30, 2017

This is related to the --iscordovaserve flag on the ionic:serve script.

Removing this removes this bug, but then renders the above flag useless.

Scrach above, still occurs with standard ionic:serve.

@brettdorrans
Copy link
Author

Issue persists in 1.2.5

@brettdorrans
Copy link
Author

This was actually caused by the default service-worker being enabled.

Commenting out from index.html and deregistering via chrome://serviceworker-internals/ fixed the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant