Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

custom copy config watch not working #659

Closed
frankkoenigstein opened this issue Jan 18, 2017 · 2 comments
Closed

custom copy config watch not working #659

frankkoenigstein opened this issue Jan 18, 2017 · 2 comments

Comments

@frankkoenigstein
Copy link

Note: for support questions, please use one of these channels:

https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/

Short description of the problem:

I added a custom config for copy in my package.json.
Afterwards watch is not getting ready and is not working:

before:

[10:47:31]  ionic-app-scripts 0.0.47 
[10:47:31]  watch started ... 
[10:47:31]  build dev started ... 
[10:47:31]  clean started ... 
[10:47:31]  clean finished in 6 ms 
[10:47:31]  copy started ... 
[10:47:31]  transpile started ... 
[10:47:34]  transpile finished in 2.63 s 
[10:47:34]  webpack started ... 
[10:47:34]  copy finished in 2.85 s 
[10:47:43]  webpack finished in 8.89 s 
[10:47:43]  sass started ... 
[10:47:44]  sass finished in 1.44 s 
[10:47:44]  build dev finished in 13.02 s 
[10:47:44]  watch ready in 13.22 s 
[10:47:44]  dev server running: http://localhost:8100/ 

After:

[11:17:05]  ionic-app-scripts 0.0.47 
[11:17:05]  watch started ... 
[11:17:05]  build dev started ... 
[11:17:05]  clean started ... 
[11:17:05]  clean finished in 2 ms 
[11:17:05]  copy started ... 
[11:17:05]  transpile started ... 
[11:17:08]  transpile finished in 2.63 s 
[11:17:08]  webpack started ... 
[11:17:08]  copy finished in 2.84 s 
[11:17:16]  webpack finished in 7.97 s 
[11:17:16]  sass started ... 
[11:17:17]  sass finished in 1.33 s 
[11:17:17]  build dev finished in 11.98 s 
[11:17:17]  dev server running: http://localhost:8100/ 

What behavior are you expecting?

Watch should work with custom copy config.

Steps to reproduce:

  1. Add config in package.json
  "config": {
    "ionic_copy": "./config/copy.config.js"
  },
  1. Create custom config file
module.exports = {
  copyMaterialFonts: {
    src: ['{{ROOT}}/node_modules/material-design-icons/iconfont/*.+(eot|ttf|woff|woff2)'],
    dest: '{{WWW}}/assets/fonts'
  }
}
  1. run ionic serve

Which @ionic/app-scripts version are you using?
0.0.47

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

@frankkoenigstein frankkoenigstein changed the title custom copy config watch custom copy config watch not working Jan 18, 2017
@twinj
Copy link
Contributor

twinj commented Jan 23, 2017

I tried this with the version 1.0.0 of the app scripts and it works on both ionic serve and emulate.

@danbucholtz
Copy link
Contributor

Fixed in newer versions.

Thanks,
Dan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants