loading state for gallery and model list #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
blessedcoolant and
psychedelicious
as code owners
Contributor
|
Because the Fixed this by appending 20 dummy items to the images array, and displaying a skeleton within the virtuoso component instead. Now it displays however many images area already loaded, followed by 20 skeletons if loading. On first load, it still displays 20 skeletons while loading. |
psychedelicious
force-pushed
the
maryhipp/skeleton
branch
from
37511af to
972ab35
Compare
psychedelicious
approved these changes
Jul 1, 2023
Contributor
|
I don't think we need any of the is ready stuff, it all seems to work fine for me on this PR |
psychedelicious
force-pushed
the
maryhipp/skeleton
branch
from
972ab35 to
ee0205e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to keep suspense loading state so that $client is created correctly in time for API requests
Do we need to keep the more global
isAppReadystuff?