add basic autocomplete functionality to node cli #3035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lstein
commented
Mar 26, 2023
lstein
commented
- Commands, invocations and their parameters will now autocomplete using introspection.
- Two types of parameter arguments will also autocomplete:
- --sampler_name will autocomplete the scheduler name
- --model will autocomplete the model name
- There don't seem to be commands for reading/writing image files yet, so path autocompletion is not implemented
- Commands, invocations and their parameters will now autocomplete using introspection. - Two types of parameter *arguments* will also autocomplete: - --sampler_name will autocomplete the scheduler name - --model will autocomplete the model name - There don't seem to be commands for reading/writing image files yet, so path autocompletion is not implemented
Member
|
Very nice! |
hipsterusername
approved these changes
Mar 26, 2023
Contributor
psychedelicious
left a comment
psychedelicious
left a comment
There was a problem hiding this comment.
Works great, thanks!
Contributor
|
Is there an autocompleter for ArgParse we could just build on top of? I don't know if that would be worthwhile? e.g. https://github.com/kislyuk/argcomplete |
Kyle0654
suggested changes
Mar 26, 2023
Contributor
Kyle0654
left a comment
Kyle0654
left a comment
There was a problem hiding this comment.
The model shouldn't be on the command line (since there's no concept of "current" model in nodes). Otherwise, everything looks fine.
1. Prompt has changed to "invoke> ". 2. Function to initialize the autocompleter has been renamed "set_autocompleter()"
Kyle0654
approved these changes
Mar 28, 2023
Contributor
Kyle0654
left a comment
Kyle0654
left a comment
There was a problem hiding this comment.
Approving, but with one suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.