• Updated best practices

• Updated index with new contribution guide link

Author: Millu

docs/contributing/CONTRIBUTING.md

@@ -12,10 +12,10 @@ To join, just raise your hand on the InvokeAI Discord server (#dev-chat) or the
 ### Areas of contribution: 
 
 #### Development
-If you’d like to help with development, please see our [development guide](docs/contributing/.contribution_guides/development.md). If you’re unfamiliar with contributing to open source projects, there is a tutorial contained within the development guide.
+If you’d like to help with development, please see our [development guide](contribution_guides/development.md). If you’re unfamiliar with contributing to open source projects, there is a tutorial contained within the development guide.
 
 #### Documentation
-If you’d like to help with documentation, please see our [documentation guide](docs/contributing/.contribution_guides/documenation.md).
+If you’d like to help with documentation, please see our [documentation guide](contribution_guides/documenation.md).
 
 #### Translation
 If you'd like to help with translation, please see our [translation guide](docs/contributing/.contribution_guides/translation.md).
@@ -32,7 +32,7 @@ This project is a combined effort of dedicated people from across the world. [C
 
 ### Code of Conduct
 
-The InvokeAI community is a welcoming place, and we want your help in maintaining that. Please review our Code of Conduct **<link to code of conduct>** to learn more. 
+The InvokeAI community is a welcoming place, and we want your help in maintaining that. Please review our [Code of Conduct](../../CODE_OF_CONDUCT.md) to learn more. 
 
 ### Support
 

docs/contributing/contribution_guides/development.md

@@ -9,6 +9,7 @@ For more information, please review our area specific documentation:
 * #### [InvokeAI Architecure](../ARCHITECTURE.md)
 * #### [Frontend Documentation](development_guides/contributingToFrontend.md)
 * #### [Node Documentation](../INVOCATIONS.md)
+* #### [Local Development](../LOCAL_DEVELOPMENT.md)
 
 If you don't feel ready to make a code contribution yet, no problem! You can also help out in other ways, such as [documentation](documentation.md) or [translation](translation.md).
 
@@ -20,44 +21,52 @@ There are two paths to making a development contribution:
 
 *Regardless of what you choose, please post in the  [#dev-chat](https://discord.com/channels/1020123559063990373/1049495067846524939) channel of the Discord before you start development in order to confirm that the issue or feature is aligned with the current direction of the project. We value our contributors time and effort and want to ensure that no one’s time is being misspent.*
 
+## Best Practices: 
+* Keep your pull requests small. Smaller pull requests are more likely to be accepted and merged
+* Comments! Commenting your code helps reviwers easily understand your contribution
+* Use Python and Typescript’s typing systems, and consider using an editor with [LSP](https://microsoft.github.io/language-server-protocol/) support to streamline development
+* Make all communications public. This ensure knowledge is shared with the whole community
+
 ## **How do I make a contribution?**
 
 Never made an open source contribution before? Wondering how contributions work in our project? Here's a quick rundown!
 
-1. Find a [good first issue](https://github.com/invoke-ai/InvokeAI/contribute) that you are interested in addressing or a feature that you would like to add. Then, reach out to our team in the [#dev-chat](https://discord.com/channels/1020123559063990373/1049495067846524939) channel of the Discord to ensure you are  setup for success. 
+Before starting these steps, ensure you have your local environment [configured for development](../LOCAL_DEVELOPMENT.md).
+
+1.  Find a [good first issue](https://github.com/invoke-ai/InvokeAI/contribute) that you are interested in addressing or a feature that you would like to add. Then, reach out to our team in the [#dev-chat](https://discord.com/channels/1020123559063990373/1049495067846524939) channel of the Discord to ensure you are  setup for success. 
 2. Fork the [InvokeAI](https://github.com/invoke-ai/InvokeAI) repository to your GitHub profile. This means that you will have a copy of the repository under **your-GitHub-username/InvokeAI**.
 3. Clone the repository to your local machine using:
 
 ```bash
-**git clone** https://github.com/your-GitHub-username/InvokeAI.git
+git clone https://github.com/your-GitHub-username/InvokeAI.git
 ```
 
 1. Create a new branch for your fix using:
 
 ```bash
-**git checkout -b branch-name-here**
+git checkout -b branch-name-here
 ```
 
 1. Make the appropriate changes for the issue you are trying to address or the feature that you want to add.
 2. Add the file contents of the changed files to the "snapshot" git uses to manage the state of the project, also known as the index:
 
 ```bash
-**git add insert-paths-of-changed-files-here**
+git add insert-paths-of-changed-files-here
 ```
 
 1. Store the contents of the index with a descriptive message.
 
 ```bash
-**git commit -m "Insert a short message of the changes made here"**
+git commit -m "Insert a short message of the changes made here"
 ```
 
 1. Push the changes to the remote repository using
 
 ```markdown
-**git push origin branch-name-here**
+git push origin branch-name-here
 ```
 
-1. Submit a pull request to the **main** branch of the InvokeAI repository.
+1. Submit a pull request to the **development** branch of the InvokeAI repository.
 2. Title the pull request with a short description of the changes made and the issue or bug number associated with your change. For example, you can title an issue like so "Added more log outputting to resolve #1234".
 3. In the description of the pull request, explain the changes that you made, any issues you think exist with the pull request you made, and any questions you have for the maintainer. It's OK if your pull request is not perfect (no pull request is), the reviewer will be able to help you fix any problems and improve it!
 4. Wait for the pull request to be reviewed by other collaborators.
@@ -76,5 +85,5 @@ For backend related work, please reach out to **@pyschedelicious, @blessedcoolan
 
 ## **What does the Code of Conduct mean for me?**
 
-Our [Code of Conduct](../../CODE_OF_CONDUCT.md)  means that you are responsible for treating everyone on the project with respect and courtesy regardless of their identity. If you are the victim of any inappropriate behavior or comments as described in our Code of Conduct, we are here for you and will do the best to ensure that the abuser is reprimanded appropriately, per our code.
+Our [Code of Conduct](CODE_OF_CONDUCT.md)  means that you are responsible for treating everyone on the project with respect and courtesy regardless of their identity. If you are the victim of any inappropriate behavior or comments as described in our Code of Conduct, we are here for you and will do the best to ensure that the abuser is reprimanded appropriately, per our code.
 

docs/index.md

@@ -221,14 +221,10 @@ get solutions for common installation problems and other issues.
 
 Anyone who wishes to contribute to this project, whether documentation,
 features, bug fixes, code cleanup, testing, or code reviews, is very much
-encouraged to do so. If you are unfamiliar with how to contribute to GitHub
-projects, here is a
-[Getting Started Guide](https://opensource.com/article/19/7/create-pull-request-github).
-
-A full set of contribution guidelines, along with templates, are in progress,
-but for now the most important thing is to **make your pull request against the
-"development" branch**, and not against "main". This will help keep public
-breakage to a minimum and will allow you to propose more radical changes.
+encouraged to do so. 
+
+[Please take a look at our Contribution documentation to learn more about contributing to InvokeAI. 
+](contributing/CONTRIBUTING.md)
 
 ## :octicons-person-24: Contributors
 

mkdocs.yml

@@ -143,6 +143,7 @@ nav:
       - Documentation: 'contributing/contribution_guides/documentation.md'
       - Translation: 'contributing/contribution_guides/translation.md'
       - Tutorials: 'contributing/contribution_guides/tutorials.md'
+      - Local Development: contributing/LOCAL_DEVELOPMENT.md
     - Changelog: 'CHANGELOG.md'
     - Deprecated:
       - Command Line Interface: 'deprecated/CLI.md'