Skip to content

Conversation

@absolutezero13
Copy link
Contributor

Description

The comment I remove exists above "reset" method, I think it's mistakenly copied and pasted above setConfigSettings method

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • [x ] Yes
  • My change supports the following platforms;
    • [x ] Android
    • [x ] iOS
    • [ x] Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • [x ] No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Oct 30, 2025

@absolutezero13 is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - agreed - chased setConfigSettings through implementation quickly and it is not platform specific, does look like copy/paste error in the doc comments, thanks for noticing and posting the PR

If you haven't already - just needs the CLA signed (yes...even for such a tiny change, sorry) than can merge

@absolutezero13
Copy link
Contributor Author

@mikehardy Signed

@mikehardy mikehardy merged commit 3d0d497 into invertase:main Oct 31, 2025
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants