Skip to content

Conversation

@igdianov
Copy link
Collaborator

@igdianov igdianov commented Feb 3, 2020

Fixes #239

@igdianov igdianov self-assigned this Feb 3, 2020
@igdianov igdianov added the bug label Feb 3, 2020
@igdianov
Copy link
Collaborator Author

igdianov commented Feb 3, 2020

@molexx Here is the fix. Let me know if this work for you. I will need to add a few tests and merge it quickly.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #240 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
+ Coverage     70.66%   70.78%   +0.12%     
- Complexity      942      949       +7     
============================================
  Files            65       65              
  Lines          4421     4426       +5     
  Branches        661      661              
============================================
+ Hits           3124     3133       +9     
+ Misses         1019     1015       -4     
  Partials        278      278              
Impacted Files Coverage Δ Complexity Δ
...a/query/schema/impl/GraphQLJpaExecutorContext.java 100.00% <0.00%> (+11.53%) 7.00% <0.00%> (+3.00%) ⬇️
.../schema/impl/GraphQLJpaExecutorContextFactory.java 76.00% <0.00%> (+24.00%) 8.00% <0.00%> (+4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 510c5bf...40df034. Read the comment docs.

@molexx
Copy link
Contributor

molexx commented Feb 3, 2020

Yes, works for me, thanks!

@igdianov igdianov merged commit e60eb50 into master Feb 28, 2020
@igdianov igdianov deleted the fix-GH-239-graphql-field-visibility branch February 28, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQLFieldVisibility not used

3 participants