Skip to content

fix(GH-193): Fixed error in GQL Queries when total or pages is included with condition where: NOT_EXISTS or EXISTS #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igdianov merged 2 commits into from
Oct 6, 2019
Merged

fix(GH-193): Fixed error in GQL Queries when total or pages is included with condition where: NOT_EXISTS or EXISTS #201

igdianov merged 2 commits into from
Oct 6, 2019

Conversation

@igdianov
Copy link
Collaborator

@igdianov igdianov commented Oct 6, 2019 •
edited
Loading

Fixes #193

@igdianov igdianov self-assigned this Oct 6, 2019
@igdianov igdianov added the bug label Oct 6, 2019
@codecov
Copy link

codecov bot commented Oct 6, 2019 •
edited
Loading

Codecov Report

Merging #201 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
+ Coverage     73.67%   73.69%   +0.02%     
  Complexity      877      877              
============================================
  Files            50       50              
  Lines          3708     3711       +3     
  Branches        626      626              
============================================
+ Hits           2732     2735       +3     
  Misses          698      698              
  Partials        278      278
Impacted Files Coverage Δ Complexity Δ
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 92.7% <100%> (+0.23%) 26 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d99c3b...c1e4e9e. Read the comment docs.

@igdianov igdianov merged commit 40a0e2d into master Oct 6, 2019
@igdianov igdianov deleted the igdianov-fix-exists-query branch October 6, 2019 21:03
@igdianov igdianov mentioned this pull request Oct 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@igdianov igdianov

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in GQL Queries when total or pages is included with condition where: NOT_EXISTS or EXISTS

3 participants

@igdianov @SinaiNIN