feat: Adding url property for getting emoji's url from the emoji's icon
#783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAxYoLo01
reviewed
May 9, 2022
mAxYoLo01
reviewed
May 9, 2022
mAxYoLo01
reviewed
May 9, 2022
AstreaTSS
added
on hold
Co-authored-by: Max <[email protected]>
Co-authored-by: Max <[email protected]>
Co-authored-by: Max <[email protected]>
Contributor
Author
|
OK, with the help of Max, I think this is ready to be merged. |
Member
|
Noted! Just note that this PR is on hold the bug fix PRs are merged. |
EepyElvyra
suggested changes
May 10, 2022
EepyElvyra
suggested changes
May 10, 2022
Toricane
suggested changes
May 11, 2022
Contributor
Toricane
left a comment
Toricane
left a comment
There was a problem hiding this comment.
Small docstring suggestion
Co-authored-by: Toricane <[email protected]>
1 task
Toricane
removed
the
on hold
EepyElvyra
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This pull request is about adding an
urlproperty underinteractions.Emoji. Currently, the only way to get the emoji's id is by getting the emoji's id, then create an url with/emojis/{emoji.id}.pngor/emojis/{emoji.id}.gifif that emoji is an animated one. The propertyurlwill make it easier to get the emoji's URL.Checklist
pre-committo format and lint the change(s) made.3.8.6and higher.urlproperty for getting theEmoji's URL #782