Skip to content

Conversation

@spinnerich
Copy link
Contributor

Description

This brings general quality improvements.

  • Merging isinstance calls
  • Removing unnecessary dict.keys()
  • Removed unnecessary init of RequestFailure (because it does not change base classes init)
  • More Specific IncorrectFormat error message
  • Simplifying check for send_type
  • Inline comments should contain 2 spaces before # (according to PEP)
  • guild_id defaults to None (get_all_commands) Guild id required #52

- Merging isinstance calls
- Removing unecessary dict.keys()
- Removed unnecessary __init__ of RequestFailure
- More Specific IncorrectFormat error message
- Simplifying check for send_type
- Inline comments should contain 2 spaces before # (according to PEP)
- guild_id defaults to None (get_all_commands)
@eunwoo1104
Copy link
Contributor

Merging this pull request. Thank you for contributing!

@eunwoo1104 eunwoo1104 merged commit 80e0494 into interactions-py:master Jan 8, 2021
@eunwoo1104 eunwoo1104 mentioned this pull request Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants