Fix not working selects and weird choice behavior; add defer for components and fix responding to components #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/pre-commit/pre-commit-hooks: v3.2.0 → v4.0.1](pre-commit/pre-commit-hooks@v3.2.0...v4.0.1) - [github.com/psf/black: 21.8b0 → 21.12b0](psf/black@21.8b0...21.12b0) - https://gitlab.com/pycqa/flake8 → https://github.com/PyCQA/flake8 - [github.com/PyCQA/flake8: 3.9.2 → 4.0.1](PyCQA/flake8@3.9.2...4.0.1) - [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1)
[pre-commit.ci] pre-commit autoupdate
EepyElvyra
changed the title
7 tasks
modified send and edit to work with defer fixed some bugs
EepyElvyra
changed the title
EepyElvyra
changed the title
i0bs
suggested changes
Dec 16, 2021
Contributor
i0bs
left a comment
i0bs
left a comment
There was a problem hiding this comment.
Cleaner approach than using a direct type(value) check. We generally use isinstance() for most type comparisons because we want to apply the actual instance property to a known typing alias, which works well for when we use the typing module.
Contributor
|
Additionally, resolve merge conflicts with |
Contributor
Author
|
should be all done now |
Contributor
|
Merging this pull request, thank you for your contribution! Welcome to the contributors table. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this Pull Request
Fixes Error when creating selectoptions
Seperates Button and Select when sending
Converts options to dict before sending
when syncing options are called twice, while choices are a dict the second time not having the
._jsonattributeAlso, I added
deferto components and fixed the problem that always the original message was updated instead of sending a newChecklist
pre_push.pyscript to format and lint the change(s) made.3.6.X.