feat: Paginate guilds when syncing #1185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing bot's guilds when syncing
EepyElvyra
reviewed
Dec 1, 2022
AstreaTSS
reviewed
Dec 2, 2022
Member
AstreaTSS
left a comment
AstreaTSS
left a comment
There was a problem hiding this comment.
Going through every single guild is a very slow operation. Perhaps a warning would be best? Maybe advise the user to not do this if more than one iteration is needed?
Also, while this doesn't relate to this PR, maybe adding in a toggle to disable guild-based syncing would be a good feature too, as many only need to update global commands.
AstreaTSS
reviewed
Dec 2, 2022
mAxYoLo01
changed the title
Contributor
Author
|
Ok, I have modified the PR to make the function private to Client, as we already have |
Catalyst4222
suggested changes
Dec 2, 2022
Catalyst4222
approved these changes
Dec 2, 2022
Contributor
Author
|
PR was tested and it resolves the issue that one person had |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Previously, the library did not account for bots which were present in more than 200 guilds BUT used guild commands. Now, the function when syncing uses a paginator to make sure all guilds are acquired.
Checklist
pre-commitcode linter has been run over all edited files to ensure the code is linted.3.8.6and higher.I've made this pull request: (check all that apply)
This is: